Create 3-zone adapter for office visualization

[williamthorsen]

Problem

The office visualization needs a spatial adapter that maps the visualization-agnostic LogicalSceneState (#299) to the 3-zone facility layout (prep area, workshop, governor's office). Branch 295's implementation used a 5-room layout that has been superseded.

Context

With #299 providing LogicalSceneState — a stable snapshot of what each agent and artifact is doing — this ticket covers the office-specific spatial layer: assigning entities to zones and slots, calculating corridor paths, resolving pixel positions, detecting changes, and planning transitions.

The 3-zone layout is defined in packages/factory/docs/visions/facility-architecture.md:

• Prep area (top-left): architect + planner workstations
• Workshop (top-right): coder + 3–5 reviewer workstations + whiteboard display
• Governor's office (bottom, full width): orchestrator desk + delivery table + control console

Salvageable code exists on branch 295-salvage for the position resolver, differ, and transition planner. The room definitions, slot assignments, corridor paths, and agent assignments need rewriting for the new zones.

The adapter consumes LogicalSceneState, not CanonicalRunStatus — no logical state derivation in this layer.

Depends on: #299 (shared logical scene state)

Solution

1. Zone definitions

Define 3 zones replacing the old 5 rooms:

Zone	ID	Slots
Prep area	prep	prep-ws-0 (architect), prep-ws-1 (planner), prep-display-0
Workshop	workshop	workshop-ws-0 (coder), workshop-ws-1 through workshop-ws-5 (reviewers), workshop-display-0 (whiteboard)
Governor's office	governor	governor-ws-0 (orchestrator), governor-storage-0/-1 (delivery table), governor-display-0 (control console)

2. Office adapter

mapLogicalToOffice(logical: LogicalSceneState): OfficeSceneConfig

Maps agents to zone/slot assignments based on phase, derives zone states, assigns artifacts to producer slots. Consumes the output of #299.

3. Corridor paths

Three zone pairs, each bidirectional:

• prep ↔ workshop (horizontal gap between upper zones)
• prep ↔ governor (vertical, through doorway)
• workshop ↔ governor (vertical, through doorway)

4. Downstream layers (adapted from 295-salvage)

• Position resolver: OfficeSceneConfig + FacilityLayout → ResolvedPositions
• Differ: diffOfficeConfigs(prev, next) → OfficeDiff
• Transition planner: planTransitions(diff, positions, layout) → TransitionPlan
• OfficeScene: Excalibur scene wiring the pipeline together (geometric placeholders)

5. Interfaces

• OfficeSceneConfig as the scene snapshot type
• FacilityLayout with query methods (slotPosition, corridorPath, etc.)
• OfficeDiff + TransitionPlan for the animation pipeline

6. Out of scope

• Thought bubbles (Structured review findings in run data and factory visualization #301, Thought bubble cycling behavior #302 — architecture is open to extension)
• Tileset rendering / sprite integration
• Pipeline panel, whiteboard visual, control console UI
• Click-to-chat interaction

Acceptance criteria

• 3-zone definitions with correct slot assignments
• mapLogicalToOffice() correctly assigns agents and artifacts to zones/slots
• Corridor paths work for all zone pairs
• Position resolver produces correct pixel coordinates for the new layout
• Differ detects changes across all entity types
• Transition planner produces valid animation instructions
• OfficeScene integrates the full pipeline with geometric placeholders
• Comprehensive tests for all layers
• No logical state derivation in the office layer — it consumes LogicalSceneState

[williamthorsen]

Note from #299 implementation: isPresent<T> is now defined in four places across the factory codebase (artifact-utils.ts, phase-inference.ts, run-to-catwalk.ts, run-to-factory-floor.ts). When migrating catwalk/factory-floor to consume the shared layer, consolidate on the artifact-utils.ts export.

[williamthorsen]

Insight from orchestrated run 20260315-085456Z: The implementation uses 3 governor storage slots (governor-storage-0 through -2) instead of the spec's 2. The 3-slot design works better with the modular cycling logic (storageCounter % 3) across the workflow's multi-artifact phases — artifacts distribute more evenly and avoid visual stacking at the delivery table.

[williamthorsen]

Spec deviations from orchestrated run 20260315-085456Z

Two intentional deviations from the ticket spec in the implementation:

1. Slot naming: All workstation slots use -desk- infix (e.g., prep-desk-0, workshop-desk-0) instead of the spec's -ws-. The abbreviation was ambiguous (workstation? workshop?) and desk better fits the office metaphor. The orchestrator slot was already governor-desk-0.

2. Governor storage slot count: 3 slots (governor-storage-0 through -2) instead of the spec's 2. The cycling logic (storageCounter % 3) distributes delivered artifacts more evenly across the delivery table for runs with many artifacts.

3. Display slots deferred: prep-display-0, workshop-display-0, governor-display-0 are not yet defined in zone definitions — they serve UI purposes (whiteboard, control console) tracked in Implement office visualization with React canvas and animation #307.

Follow-up implementation tracked in #307.