Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/agents/content/skills/commit/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ Do not include the ticket ID in the commit title. The branch name carries it. In

## Body guidelines

**No hard line breaks.** Write each paragraph or list item as a single long line. Do not insert newlines to wrap at a column width. Every tool that renders commit messages handles wrapping; manual breaks produce ragged text.

See `../_data/commit-format.md` for body formatting rules (punctuation, backtick formatting, paragraph structure, and what to omit).

## Changes touching multiple workspaces
Expand Down
23 changes: 22 additions & 1 deletion packages/agents/content/skills/common-mistakes/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,23 @@ Commit titles must describe the **code change**, not the process. Titles like "A

### Hard line breaks in commit body

Do not insert newlines to wrap the commit body at a fixed column width. Write naturally as continuous text. Let the terminal or viewer handle wrapping. This applies to both prose paragraphs and list items.
This is a frequently repeated mistake. Do not insert newlines to wrap the commit body at a fixed column width. Every tool that displays commit messages (GitHub, Bitbucket, terminal pagers) handles wrapping. Manually broken lines create ragged text, produce unnecessary diffs when reflowed, and make commit messages harder to search.

Write each paragraph or list item as a single unwrapped line. Let the viewer handle wrapping.

Wrong:

```
Add no-automated-tests-in-test-plan rule to summarize-change and
prepare-pr skills. Add PR comment labeling rules to review-criteria
(finding IDs map to descriptive labels like `fixme:`, `warning:`).
```

Right:

```
Add no-automated-tests-in-test-plan rule to summarize-change and prepare-pr skills. Add PR comment labeling rules to review-criteria (finding IDs map to descriptive labels like `fixme:`, `warning:`).
```

## Pull requests

Expand Down Expand Up @@ -70,3 +86,8 @@ These mistakes span multiple categories:
- Conditional expects that can silently pass
- Tests that pass coincidentally despite logical flaws
- Missing edge case coverage

### Finding IDs out of context

- Finding IDs (`F1`, `W2`, `T3`, etc.) belong only in review documents. Never use them in commit messages, PR descriptions, tickets, or plans.
- When posting findings as PR comments, use descriptive labels (`fixme:`, `warning:`, `todo:`, `suggestion:`, `recommendation:`) instead. See `review-criteria` skill for the full mapping.
1 change: 1 addition & 0 deletions packages/agents/content/skills/prepare-pr/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,4 @@ Example: `20250121-1530Z_auto-share-exception_pull-request.md`
- The PR description file is a copy of the change summary
- This separation allows for PR-specific modifications if needed
- The change summary serves as the source of truth for branch work
- Never list automated checks (formatting, linting, typechecking, unit tests) in a test plan. They run automatically in CI.
12 changes: 12 additions & 0 deletions packages/agents/content/skills/review-criteria/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,15 @@ Used by review-producing skills and agents for structured code review findings.
### Re-review severity escalation

`S → R → T → W → F`. L findings are never escalated.

## PR comment format

When posting findings as PR comments (e.g., inline comments on a pull request), use a descriptive label instead of the raw finding ID. Finding IDs like `F1` or `W2` are internal to review documents and have no meaning to readers in PR context.

| Finding prefix | PR comment label |
| -------------- | ----------------- |
| `F` | `fixme:` |
| `W` | `warning:` |
| `T` | `todo:` |
| `S` | `suggestion:` |
| `R` | `recommendation:` |
1 change: 1 addition & 0 deletions packages/agents/content/skills/summarize-change/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ Generated by: {Agent name} (model: {model})
- Omit inapplicable Details subsections
- Order Details subsections per `work-types.md` priority: Primary → Secondary → Tertiary
- `## What` and `## Why` are required; Details subsections are optional
- Never list automated checks (formatting, linting, typechecking, unit tests) in a test plan. They run automatically in CI.

## As a PR description

Expand Down
Loading