Skip to content

#321 Clean up remaining get-session-context migration loose ends #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williamthorsen merged 1 commit into from
Mar 17, 2026
Merged

#321 Clean up remaining get-session-context migration loose ends #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/agents/content/skills/_data/artifact-conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ For contexts where the manifest is unavailable (e.g., standalone scripts without
{base_dir}/projects/{project-slug}/tickets/{ticket-id}/
```

Ticket-level artifacts and run directories both live here. Use `get-ticket-id` for the ticket ID.
Ticket-level artifacts and run directories both live here. Use `get-session-context` to obtain `ticket_id`.

### Run paths

Expand Down
1 change: 0 additions & 1 deletion packages/agents/content/subagents/aspect-code-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ maxTurns: 20
skills:
- anti-patterns
- common-mistakes
- get-session-context
- review-criteria
---

Expand Down
1 change: 0 additions & 1 deletion packages/agents/content/subagents/aspect-silent-failure-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ tools: [Read, Grep, Glob, Bash, Write]
maxTurns: 20
skills:
- anti-patterns
- get-session-context
- review-criteria
---

Expand Down
1 change: 0 additions & 1 deletion packages/agents/content/subagents/aspect-test-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ maxTurns: 20
skills:
- anti-patterns
- common-mistakes
- get-session-context
- review-criteria
---

Expand Down
3 changes: 1 addition & 2 deletions packages/agents/content/subagents/orchestrated-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ maxTurns: 30
skills:
- anti-patterns
- common-mistakes
- get-session-context
- review-criteria
- software-engineering
---
Expand All @@ -29,7 +28,7 @@ You will receive:

## Process

1. **Get the diff**: run `git diff <merge-base-sha>..HEAD` to see all changes in scope, where `<merge-base-sha>` is the pre-resolved SHA provided in your task prompt. If none was provided, compute it yourself: invoke `get-session-context`, then run `git merge-base HEAD <default-branch>` to get the SHA.
1. **Get the diff**: run `git diff <merge-base-sha>..HEAD` to see all changes in scope, using the merge-base SHA provided in your task prompt.
2. **Read changed files**: read the full files, not just diffs, to understand context
3. **Evaluate against criteria**: apply review-criteria skill
4. **Form preliminary findings**: classify each finding into the F/W/T/R/S/L scheme and determine overall criticality
Expand Down
Loading