Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions packages/agents/content/skills/_data/design-priorities.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,24 @@ B. Extract a small dedicated module with a narrow interface and inject it.
**Convenience-led ranking** (don't do this):

```
1. ■■■ Extend the god-class: ➕ minimal diff; ➕ no new files; ➕ matches surrounding code.
2. ■□□ Extract a module: ➖ more files; ➖ touches injection sites.
1. ■■■ Extend the god-class:
➕ minimal diff;
➕ no new files;
➕ matches surrounding code.
2. ■□□ Extract a module:
➖ more files;
➖ touches injection sites.
```

**Correctness-led ranking** (do this):

```
1. ■■■ Extract a module: ➕ narrow interface; ➕ testable in isolation; ➕ untangles concerns the god-class already conflates.
2. □□□ Extend the god-class: ➖ deepens an existing SRP violation; convenience gain is one-off, complexity cost compounds.
1. ■■■ Extract a module:
➕ narrow interface;
➕ testable in isolation;
➕ untangles concerns the god-class already conflates.
2. □□□ Extend the god-class:
➖ deepens an existing SRP violation; convenience gain is one-off, complexity cost compounds.
```

The factual lists about each option are similar; the **ranking** flips because the criteria changed.
Expand Down
19 changes: 13 additions & 6 deletions packages/agents/content/skills/_data/recommendation-gradient.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,28 @@ Rank options on correctness — behavior, API quality, architectural soundness,

## Format

Marker, then option title and colon, then inline pros (`➕`) and cons (`➖`) separated by `;`. Lead with the strongest argument. One line per option when possible.
Marker, then option title and colon. Each pro (`➕`) and con (`➖`) goes on its own line, indented by 3 spaces. Apply this even when an option has only one pro or con. Lead with the strongest argument. Use semicolons between items and a period on the last.

## Examples

```
Want me to:
1. ■□□ Use a single config file: ➕ minimal surface area; ➖ couples concerns.
2. ■■■ Split into two configs: ➕ separates lifecycle and runtime concerns; ➕ matches existing repo pattern.
3. □□□ Use three configs: ➖ over-decomposed for current scope.
1. ■□□ Use a single config file:
➕ minimal surface area;
➖ couples concerns.
2. ■■■ Split into two configs:
➕ separates lifecycle and runtime concerns;
➕ matches existing repo pattern.
3. □□□ Use three configs:
➖ over-decomposed for current scope.
```

```
Want me to:
1. Use camelCase: ➕ matches the host file's local style.
2. Use kebab-case: ➕ matches the package's public API style.
1. Use camelCase:
➕ matches the host file's local style.
2. Use kebab-case:
➕ matches the package's public API style.
```

## Don'ts
Expand Down
2 changes: 1 addition & 1 deletion packages/agents/content/skills/design-and-plan/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Invoke the `assess-ticket` skill with the resolved ticket source and mode `drift
- Success criteria and edge cases
- Prefer multiple choice when possible
- Only one question per message
- When using numbered options, follow the [recommendation gradient](../_data/recommendation-gradient.md): mark each option with ■■■ / ■■□ / ■□□ / □□□ and inline `➕` pros, `➖` cons (e.g., `1. ■■■ Option title: ➕ pro; ➖ con.`).
- When using numbered options, follow the [recommendation gradient](../_data/recommendation-gradient.md): mark each option with ■■■ / ■■□ / ■□□ / □□□ and list `➕` pros and `➖` cons per the format defined there.

### Phase 3: Converge on a design

Expand Down
Loading