Skip to content

#706 Reframe legacy finding-ID rule to prevent ID collisions #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williamthorsen merged 1 commit into from
Jun 2, 2026
+7 −7
Merged

#706 Reframe legacy finding-ID rule to prevent ID collisions #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/agents/content/skills/_data/artifact-conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,10 +793,10 @@ Consumers that present or report findings (review skills, wrap-up, response arti
- Documentation improvements
- **Gate:** Raise only when the change aligns with a codebase convention the code violates, has measurable improvement evidence (perf, correctness, readability with a concrete example), or follows a widely accepted external standard (linter rule, language spec, ecosystem norm with a citation). "Another valid way to write it" does not qualify.

**Legacy (-L suffix)** — pre-existing code observation:
**Legacy (`-L` suffix)** — pre-existing code observation:

- Issues in code not authored in this branch — use the same severity letter as the equivalent author finding plus a `-L` suffix
- Legacy findings share the numbering sequence with author findings of the same severity letter. Example: If a review has `F1`, `F2` (author findings), the first legacy FIXME is `F3-L`
- Issues in code not authored in this branch — use the same severity letter as the equivalent author finding.
- The `-L` is a marker, not part of the ID — the ID is the number in front of it. Assign that number from the shared per-letter sequence as if this were an author finding, then append `-L`. Example: after author findings `F1`, `F2`, the first legacy FIXME is `F3-L`.
- Set the `**Severity:**` field to `{severity} (legacy)` — e.g., `critical (legacy)`, `warning (legacy)`, `suggestion (legacy)`
- Frame as future opportunities, not current defects
- Never count against the review score
Expand Down
2 changes: 1 addition & 1 deletion packages/agents/content/skills/respond-to-review/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ The body following the frontmatter has this structure:

### Legacy 🔍

#### F3-L: {title from review}
#### F2-L: {title from review}

- **Disposition:** ACCEPT | REJECT
- **Rationale:** {reasoning}
Expand Down
2 changes: 1 addition & 1 deletion packages/agents/content/skills/review-branch/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ Uniquely number all issues for easy reference. See [finding scheme](../_data/art
- TODOs: `T{n}` — should fix, can wait for next PR
- Recommendations: `R{n}` — advisable but discretionary
- Suggestions: `S{n}` — optional improvement
- Legacy: `{F,W,T,R,S}{n}-L` — observation in pre-existing code, not authored in this change. Uses the same severity letter as the equivalent author finding plus a `-L` suffix (e.g., `F3-L`, `W2-L`)
- Legacy: `{F,W,T,R,S}{n}-L` — observation in pre-existing code, not authored in this change. Same severity letter as the equivalent author finding; number it from that letter's shared sequence first, then append `-L` as a marker (e.g., after `F1`, `F2`, the first legacy FIXME is `F3-L`)

## Output format

Expand Down
4 changes: 2 additions & 2 deletions packages/agents/content/subagents/orchestrated-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,14 @@ The finalized form of the review file. See [Incremental review writes](#incremen
- **Description:** {Optional improvement}
- **Recommendation:** {How to improve}

#### F3-L: {title}
#### F2-L: {title}

- **Location:** `src/auth/utils.ts:15`
- **Severity:** critical (legacy)
- **Description:** {Pre-existing issue observed}
- **Recommendation:** {Future opportunity}

{Use the same pattern for all severity letters: `W2-L` with `warning (legacy)`, `T1-L` with `todo (legacy)`, etc.}
{Use the same pattern for all severity letters: `W2-L` with `warning (legacy)`, `T2-L` with `todo (legacy)`, etc.}
```

If no findings, write:
Expand Down
Loading