Skip to content

#751 Set the shell-conventions rulebook to skill-only delivery #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williamthorsen merged 1 commit into from
Jun 30, 2026
Merged

#751 Set the shell-conventions rulebook to skill-only delivery #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/agents/content/guidance/rulebooks/shell-conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
slug: shell-conventions
description: Conventions for writing production-quality bash scripts in this repository.
delivery: [ambient, skill]
delivery: skill
version: 1
---

Expand Down
2 changes: 0 additions & 2 deletions packages/agents/src/commands/__tests__/sync.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ describe(syncCommand, () => {
const neutral = await readFile(neutralPath('shell-conventions'), 'utf8');
expect(neutral).toContain('# Shell script conventions');
expect(neutral).not.toContain('slug:');
expect(await readFile(projectMdPath(), 'utf8')).toContain('<!-- rulebook:shell-conventions -->');
const skill = await readFile(skillPath('consult-shell-conventions'), 'utf8');
expect(skill).toContain('name: consult-shell-conventions');
expect(skill).toContain('# Shell script conventions');
Expand All @@ -335,7 +334,6 @@ describe(syncCommand, () => {
await syncCommand(makeOptions(), projectRoot, resolveContentDir());

expect(existsSync(neutralPath('shell-conventions'))).toBe(false);
expect(await readFile(projectMdPath(), 'utf8')).not.toContain('<!-- rulebook:shell-conventions -->');
expect(existsSync(path.dirname(skillPath('consult-shell-conventions')))).toBe(false);
});

Expand Down
Loading