Skip to content

Allow extra cannon args via Helm#5023

Merged
jschaul merged 8 commits intodevelopfrom
cannon-options
Feb 11, 2026
Merged

Allow extra cannon args via Helm#5023
jschaul merged 8 commits intodevelopfrom
cannon-options

Conversation

@jschaul
Copy link
Member

@jschaul jschaul commented Feb 11, 2026

Setting this yaml

cannonArgs: ["+RTS", "-M2g", "-RTS"]

yields a process that looks like this when it runs:

tr '\0' ' ' < /proc/1/cmdline; echo
/nix/store/0424psvij1xlqnf4bw88pvrlirfj4mzd-dumb-init-1.2.5/bin/dumb-init -- /nix/store/zg65yxh6pll45hb8x87hmbfyjvy2qcik-cannon/bin/cannon +RTS -M2g -RTS

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@jschaul jschaul requested review from a team as code owners February 11, 2026 10:36
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 11, 2026
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small nit.

jschaul and others added 8 commits February 11, 2026 14:45
Setting this yaml

```
cannonArgs: ["+RTS", "-M2g", "-RTS"]
```

yields a process that looks like this when it runs:

```
tr '\0' ' ' < /proc/1/cmdline; echo
/nix/store/0424psvij1xlqnf4bw88pvrlirfj4mzd-dumb-init-1.2.5/bin/dumb-init -- /nix/store/zg65yxh6pll45hb8x87hmbfyjvy2qcik-cannon/bin/cannon +RTS -M2g -RTS
```
Co-authored-by: Leonhardt Wille <lwille@users.noreply.github.com>
Co-authored-by: Akshay Mankar <akshay@wire.com>
@jschaul
Copy link
Member Author

jschaul commented Feb 11, 2026

Drive-by fix: fix indentation of the resources block (was 2 spaces too much).

@jschaul jschaul merged commit 19d7a64 into develop Feb 11, 2026
10 checks passed
@jschaul jschaul deleted the cannon-options branch February 11, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants