Skip to content

[WPB-23644] about fetching apps and reg users#5057

Merged
fisx merged 19 commits intodevelopfrom
WPB-23644-about-fetching-apps-and-reg-users
Feb 26, 2026
Merged

[WPB-23644] about fetching apps and reg users#5057
fisx merged 19 commits intodevelopfrom
WPB-23644-about-fetching-apps-and-reg-users

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Feb 24, 2026

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx fisx force-pushed the WPB-23644-about-fetching-apps-and-reg-users branch from 7f56dfb to 2b483c2 Compare February 25, 2026 11:29
@fisx fisx force-pushed the WPB-23644-about-fetching-apps-and-reg-users branch from 05884a5 to a4da929 Compare February 25, 2026 11:43
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 25, 2026
@fisx fisx force-pushed the WPB-23644-about-fetching-apps-and-reg-users branch 2 times, most recently from b794737 to 302b823 Compare February 26, 2026 07:22
@fisx fisx force-pushed the WPB-23644-about-fetching-apps-and-reg-users branch from 302b823 to a1d3b56 Compare February 26, 2026 07:22
@fisx fisx marked this pull request as ready for review February 26, 2026 07:23
@fisx fisx requested review from a team as code owners February 26, 2026 07:23
@fisx fisx requested a review from Copilot February 26, 2026 07:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the public Brig “list team apps” endpoint to return app IDs alongside app metadata, and enhances integration-test assertions with a lightweight JSON “shape” matcher to make response validation less value-specific.

Changes:

  • Change GET /teams/:tid/apps response type from [GetApp] to [(UserId, GetApp)] and propagate through Brig API + AppSubsystem layers.
  • Add a JSON Shape DSL (Shape, shouldMatchShape, valueShape) to the integration test library, plus self-tests for it.
  • Update/add integration tests to validate app/user retrieval scenarios using shape assertions.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
services/brig/src/Brig/API/Public.hs Updates handler signature for getApps to include app IDs.
libs/wire-subsystems/src/Wire/AppSubsystem.hs Adjusts AppSubsystem effect to return (UserId, GetApp) pairs.
libs/wire-subsystems/src/Wire/AppSubsystem/Interpreter.hs Implements getAppsImpl to return (u.id, GetApp) pairs.
libs/wire-api/src/Wire/API/Routes/Public/Brig.hs Changes Servant route return type for GET /teams/:tid/apps.
integration/test/Testlib/Assertions.hs Adds Shape DSL and shouldMatchShape assertion helpers.
integration/test/Test/Shape.hs Adds self-tests for the Shape DSL.
integration/test/Test/Apps.hs Updates app tests for new response shape; adds broader test covering users/apps retrieval.
integration/test/API/Galley.hs Adds getTeamMember helper used by new test.
integration/integration.cabal Exposes Test.Shape module.
changelog.d/5-internal/WPB-23644-test-json-shapes Notes new shape assertion support in integration tests.
changelog.d/1-api-changes/WPB-23644-about-fetching-apps-and-reg-users Notes API response now includes app IDs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fisx and others added 3 commits February 26, 2026 08:48
Co-authored-by: Gautier DI FOLCO <gautier.difolco@wire.com>
…ching-apps-and-reg-users' into WPB-23644-about-fetching-apps-and-reg-users
@fisx fisx requested a review from blackheaven February 26, 2026 10:25
@fisx fisx merged commit dc24266 into develop Feb 26, 2026
9 of 10 checks passed
@fisx fisx deleted the WPB-23644-about-fetching-apps-and-reg-users branch February 26, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants