[WPB-23644] about fetching apps and reg users#5057
Merged
Conversation
7f56dfb to
2b483c2
Compare
Co-authored-by: fisx <10210727+fisx@users.noreply.github.com>
Co-authored-by: fisx <10210727+fisx@users.noreply.github.com>
05884a5 to
a4da929
Compare
b794737 to
302b823
Compare
302b823 to
a1d3b56
Compare
blackheaven
requested changes
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the public Brig “list team apps” endpoint to return app IDs alongside app metadata, and enhances integration-test assertions with a lightweight JSON “shape” matcher to make response validation less value-specific.
Changes:
- Change
GET /teams/:tid/appsresponse type from[GetApp]to[(UserId, GetApp)]and propagate through Brig API + AppSubsystem layers. - Add a JSON Shape DSL (
Shape,shouldMatchShape,valueShape) to the integration test library, plus self-tests for it. - Update/add integration tests to validate app/user retrieval scenarios using shape assertions.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/brig/src/Brig/API/Public.hs | Updates handler signature for getApps to include app IDs. |
| libs/wire-subsystems/src/Wire/AppSubsystem.hs | Adjusts AppSubsystem effect to return (UserId, GetApp) pairs. |
| libs/wire-subsystems/src/Wire/AppSubsystem/Interpreter.hs | Implements getAppsImpl to return (u.id, GetApp) pairs. |
| libs/wire-api/src/Wire/API/Routes/Public/Brig.hs | Changes Servant route return type for GET /teams/:tid/apps. |
| integration/test/Testlib/Assertions.hs | Adds Shape DSL and shouldMatchShape assertion helpers. |
| integration/test/Test/Shape.hs | Adds self-tests for the Shape DSL. |
| integration/test/Test/Apps.hs | Updates app tests for new response shape; adds broader test covering users/apps retrieval. |
| integration/test/API/Galley.hs | Adds getTeamMember helper used by new test. |
| integration/integration.cabal | Exposes Test.Shape module. |
| changelog.d/5-internal/WPB-23644-test-json-shapes | Notes new shape assertion support in integration tests. |
| changelog.d/1-api-changes/WPB-23644-about-fetching-apps-and-reg-users | Notes API response now includes app IDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Gautier DI FOLCO <gautier.difolco@wire.com>
…ching-apps-and-reg-users' into WPB-23644-about-fetching-apps-and-reg-users
blackheaven
approved these changes
Feb 26, 2026
…tching-apps-and-reg-users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d