Skip to content

Feature/Re-organize Dependencies and enable Junit4 & Junit5 execution togeter#10

Merged
oleg-nenashev merged 2 commits into
wiremock:mainfrom
bitxon:feature/re-organize-dependencies
Apr 23, 2023
Merged

Feature/Re-organize Dependencies and enable Junit4 & Junit5 execution togeter#10
oleg-nenashev merged 2 commits into
wiremock:mainfrom
bitxon:feature/re-organize-dependencies

Conversation

@bitxon
Copy link
Copy Markdown
Contributor

@bitxon bitxon commented Apr 23, 2023

Improvements:

  1. Simplify dependency management thanks to utilization BOM
  2. Allow to run Junit4 and Junit5 test together
  3. Fix Wrong indentation in pom.xml

@bitxon bitxon changed the title Feature/re organize dependencies Feature/Re-organize Dependencies and enable Juni4 & Junit5 execution togeter Apr 23, 2023
@oleg-nenashev oleg-nenashev added the chore Maintenance label Apr 23, 2023
Copy link
Copy Markdown
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! To close #8 we will still need to add some tests and documentation, but yes the JUnit5 execution should work now

@oleg-nenashev oleg-nenashev added the enhancement New feature or request label Apr 23, 2023
@oleg-nenashev oleg-nenashev merged commit 1e460c4 into wiremock:main Apr 23, 2023
@oleg-nenashev oleg-nenashev changed the title Feature/Re-organize Dependencies and enable Juni4 & Junit5 execution togeter Feature/Re-organize Dependencies and enable Junit4 & Junit5 execution togeter Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants