Update the release flow to take the version as a parameter, and pass it to JReleaser#13
Conversation
| echo "VERSION=${{ github.event.inputs.version }}" >> $GITHUB_OUTPUT | ||
| mvn versions:set -DnewVersion=${{ github.event.inputs.version }}-SNAPSHOT | ||
| git commit -m "Releasing version ${{ github.event.inputs.version }}" pom.xml | ||
| git push origin main |
There was a problem hiding this comment.
Probably should not be called explicitly, Maven Release Plugin will do the push anyway
|
|
||
| # Create a release | ||
| # Create a GitHub Release | ||
| # TODO (oleg-nenashev): Consider switching to Release Drafter if there is not significant value except fancy changelog |
There was a problem hiding this comment.
FWIW release-drafter works with issues/PRs while JReleaser works with commit messages (though it can also invoke GiHub's "native" release notes generator, which also only works with issues/PRs).
There was a problem hiding this comment.
Exactly. Both approaches have their pros and cons, though I got more used to the PR-based approach. I wanted to try out JReleaser on something in any case, at least until we have unified labeling policy and changelog format in the organization, similar to https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.yml
|
A bit of YOLO, but let's see how it works with the next release |
2 participants
As mentioned by @aalmiray in https://twitter.com/aalmiray/status/1648414396278816775, the configuration was broken, and JReleaser actually failed for the previous version. This patch should help