Simplify Extentions api - Remove overhead with id and plugins#237
Merged
Conversation
…iners-java into feature/simplify-ext-config
oleg-nenashev
added
enhancement
oleg-nenashev
changed the title
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Member
Author
|
Belated thanks to @bitxon and sorry for a loooong delay. I will merge it so that we have better API in place |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a merged version of #36 from @bitxon .
All references to Plugins are cleaned up.
I have kept
public WireMockContainer withExtension(String extensionName, Collection<String> classNames, Collection<File> jars), mostly for the QoL purposes for now