#33 Align methods of WireMockContainer and WireMockServer

[bitxon]

No description provided.

[oleg-nenashev]

baseUrl and url are actually not aligned with the common Java notation. I am not strongly against that, but maybe we could keep the compliant methods too and later maybe have them in WireMock also

[bitxon]

baseUrl and url are actually not aligned with the common Java notation. I am not strongly against that, but maybe we could keep the compliant methods too and later maybe have them in WireMock also

@oleg-nenashev What is preferred option

Option A: to have both methods like

baseUrl(); // same as in WireMockServer
getBaseUrl(); // classic getter method 
url(String);
getUrl(String);
port();
getPort();

Option B: just add suffix get

getBaseUrl();
getUrl(String);
getPort();

Personally i like option B, but then methods will be not aligned with WireMockServer class

[oleg-nenashev]

Apart from the NPE risk, it is generally okay. To address the actual use-case of following Java best practices for WiremockServer, I would generally suggest a patch in Wiremock within the scope of 3.0. At the same time, there are plenty of such APIs and maybe talking to @tomakehurst first makes sense.

Happy to approve once the NPE thing is addressed. Will enable SpotBugs too later

[oleg-nenashev]

BTW no need to force-push each time, we can always squash-merge if needed