Move runtime to Node 24, eliminate Node 20 deprecation warnings#188
Open
GeorgioCZY wants to merge 2 commits into
Open
Move runtime to Node 24, eliminate Node 20 deprecation warnings#188GeorgioCZY wants to merge 2 commits into
GeorgioCZY wants to merge 2 commits into
Conversation
- Bump local action runtime to node24 (was node20) - slackapi/slack-github-action v1.27.1 -> v3.0.3 across 7 call sites, with the v2 input shape (method, token, channel-in-payload) - actions/setup-node v4 -> v6 in test workflow; runner Node 20 -> 24 - Rebuild dist/ via npm run prepare; jest suite passes golangci-lint-action@v6 fallback left in place for repos still on v1 config (no Node 24 release supports v1 config). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
slack-github-action v3 cannot send to multiple channels in one step; the descriptions implied plural support which no longer exists. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cf995ae to
ff41fe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node20→node24(action.yml)slackapi/slack-github-action@v1.27.1call sites to@v3.0.3, adopting the v2 input shape:method: chat.postMessage,token:input (replacing theSLACK_BOT_TOKENenv), andchannelinside the JSON payloadactions/setup-node@v4→@v6in the test workflow; raises the test runner from Node 20 → 24dist/vianpm run prepareagainst Node 24After this PR, the only Node 20 reference left is
golangci/golangci-lint-action@v6ingo/lint/action.yml, which is the deliberate fallback branch for repos still on golangci-lint v1 config. No Node 24 release of that action supports v1 config — repos on v2 config already use@v9. Migrating consumers off v1 config is a separate effort.Things to verify before merging
channel-id). TheSLACK_CHANNEL_IDinput descriptions still say "channel ID(s)" — if any downstream repo was passing multiple IDs in one call, that flow will now fail.dist/shrunk by ~7k lines because the previously committed bundle was last rebuilt in Oct 2023; the source.jsis unchanged. Tests pass against the rebuilt bundle.Test plan
unitsjob runsnpm test;testjob exercises the composite action)@chore/node24-deprecation-cleanupref, watching for: Node 20 deprecation warning gone, Slack failure notifications still deliverableSLACK_CHANNEL_ID🤖 Generated with Claude Code