Conversation
✅ Deploy Preview for astro-www-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ArmandPhilippot
approved these changes
Mar 11, 2026
Member
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Looking at the action-setup README, I'm not sure how this is pointless... Is this because the pnpm store directory is always repopulated with each PR and this option should only be used when a cache can persist?
Anyway, I trust you especially with regard to performance. LGTM!
matthewp
approved these changes
Mar 11, 2026
Member
Author
We are already caching them with the node-setup action — this feature is only relevant when you don't use that (and rely on pnpm itself to manage installing Node) but I'd misunderstood it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts a configuration change I made to our CI config in #2251
I added a redundant
cacheoption after misunderstanding its purpose. This is harmless but also pointless, so we should remove it.