-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fonts: updated default subset #12731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Yeah, I don't think Since is necessary here. We only change the default and this is an experimental feature. As long the changeset specifies this is a breaking change, I think this is fine for docs!
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
|
I forgot to wait for the associated PR again...will be merged soon so shouldn't be a problem |
Description (required)
The default subset is updated. I don't think we need to add a
Sincefor thisRelated issues & labels (optional)
For Astro version:
5.?. See astro PR 14796.