Skip to content

Conversation

@florian-lefebvre
Copy link
Member

Description (required)

The default subset is updated. I don't think we need to add a Since for this

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.?. See astro PR 14796.

@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit aaf4044
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/691c43acbf07390008348080
😎 Deploy Preview https://deploy-preview-12731--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Yeah, I don't think Since is necessary here. We only change the default and this is an experimental feature. As long the changeset specifies this is a breaking change, I think this is fine for docs!

@ArmandPhilippot ArmandPhilippot added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Nov 18, 2025
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@florian-lefebvre florian-lefebvre merged commit e65d33f into main Nov 18, 2025
11 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-latin-default-subset branch November 18, 2025 15:35
@florian-lefebvre
Copy link
Member Author

I forgot to wait for the associated PR again...will be merged soon so shouldn't be a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants