Maintenance: Unify examples#198
Conversation
rotemmiz
left a comment
rotemmiz
left a comment
There was a problem hiding this comment.
Great job! This looks super neat, thanks!
I had a few minor issues, nothing big.
| "react": ">= 15.4.1", | ||
| "react-native": ">= 0.40.0" | ||
| "react": "*", | ||
| "react-native": "*" |
There was a problem hiding this comment.
The project requires RN>40 IIRC
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:2.3.0' | ||
| classpath 'com.android.tools.build:gradle:2.2.3' |
There was a problem hiding this comment.
com.android.tools.build:gradle:2.2.3 is VERY old. Let's please move to 3.0.1 or at least stay at 2.3.0
There was a problem hiding this comment.
Detox will not work with that gradle plugin version, it requires 3.x.x
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip |
There was a problem hiding this comment.
Same here please, let's move forward, not backwards.
|
@rotemmiz i updated the PR. Thanks for reviewing ;) |
rotemmiz
left a comment
rotemmiz
left a comment
There was a problem hiding this comment.
com.android.tools.build:gradle:3.0.1 requires gradle-4.1.
Were you able to run the Android playground app with the current configuration?
|
Strange. Ran it this morning and everything was fine. Deleted the app from the phone and ran it again and it was not able to build. I will take this as a task to to everytime before pushing.
|
|
One more thing that needs to be verified is what npm packs inside the package with the new structure. |
|
Perfect. Thanks for the hint. Never had a look on this to be honest. Updated the npmignore accordingly to not include e2e and playground. Just one question beside: What´s the purpose of the Just saw it in every Wix project. Just internal declaration? |
|
Thanks! |
2 participants
As discuessed, unified real life examples and examples. Also prepare test setup