RN61 upgrade#301
Conversation
| } | ||
| // componentWillMount() { | ||
| // // this.chokeTheBridge(); | ||
| // } |
There was a problem hiding this comment.
I think this should be kept in place for future reference due to this method's nature - Updated the comment to make its usage clearer.
| "detox": "^12.0.0", | ||
| "eslint": "^5.16.0", | ||
| "jest": "^24.5.0", | ||
| "jetifier": "^1.6.4", |
There was a problem hiding this comment.
this is a one-shot dep, isn't it? I think you can remove it
| "@react-native-community/eslint-config": "^0.0.3", | ||
| "@types/react-native": ">= 0.52.2", | ||
| "babel-jest": "^24.5.0", | ||
| "detox": "^12.0.0", |
| }, | ||
| "dependencies": {}, | ||
| "dependencies": { | ||
| "react-native-webview": "^7.4.3" |
There was a problem hiding this comment.
Removed. Was indeed unnecessary.
| * give correct results when using with locales other than en-US. Note that | ||
| * this variant is about 6MiB larger per architecture than default. | ||
| */ | ||
| def djscFlavor = 'org.webkit:android-jsc:+' |
There was a problem hiding this comment.
you can get rid of all'a this - both the var and the typo
| } catch (InvocationTargetException e) { | ||
| e.printStackTrace(); | ||
| } | ||
| } |
There was a problem hiding this comment.
It cannot be removed. Android build fails without this since InvocationTargetException must be caught.
| <!-- Base application theme. --> | ||
| <style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar"> | ||
| <!-- Customize your theme here. --> | ||
| <item name="android:textColor">#000000</item> |
There was a problem hiding this comment.
On purpose? yes, as part of the official RN migration guide.
Adds real value? meh.
There was a problem hiding this comment.
try to see if the app looks decent without it and if so, better remove... better not custom-theme if no need to
| classpath 'com.android.tools.build:gradle:3.3.1' | ||
| classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.0" | ||
| classpath('com.android.tools.build:gradle:3.4.2') | ||
| classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.31" |
There was a problem hiding this comment.
replace 1.3.31 with $kotlinVersion
| compileSdkVersion = 28 | ||
| targetSdkVersion = 28 | ||
| supportLibVersion = "28.0.0" | ||
| kotlinVersion = '1.3.31' |
| @@ -1,5 +1,5 @@ | |||
| rootProject.name = 'playground' | |||
|
|
|||
| apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings) | |||
| .gradle | ||
| local.properties | ||
| android/.project | ||
| android/.settings/* |
There was a problem hiding this comment.
Yes, these files should not be committed nor their changes tracked.
| android/app/libs | ||
| android/keystores/debug.keystore | ||
| *.keystore | ||
| !debug.keystore |
There was a problem hiding this comment.
Was added by RN official migration guide.
|
Looks good to me. Hopefully this will get merged |
5 participants
Upgrade to react-native 0.61.4