remove ExampleInstrumentedTest file as suggested in https://github.co…#320
Merged
Conversation
d4vidi
approved these changes
Mar 2, 2021
Contributor
|
I will merge, but not sure if can release successfully |
Contributor
Author
|
Hi @d4vidi, I really appreciate considering this PR. If you don't mind answering this, what could be the cause for the release not being successful ? I understand this lib in not maintained for now, but with a new release it could let other people, me included, to build their project with Detox without needing to refactor components because of Interactable. Again, thanks for the approval and merge. |
Contributor
|
It seems the project is not maintained to the point its release process is broken.. I will try to put in my available (though minimal) energy into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @d4vidi in wix/Detox#2157 (comment), I created this PR to remove the ExampleInstrumentedTest file since it is not needed and is causing the problem to build the project with Detox as exposed in the same Issue 2157.
Please, I kindly ask to consider this PR and release a new version of react-native-interactable to let people build Detox with no problems.