Shared Element Transition broken with safe area

[mrousavy]

🐛 Bug Report

The Shared Element Transition seems to not animate to the correct bounds.

Here's a video of the SET breaking on a phone that has left and right "edges"

20210507-154223-720x1480.mp4

In this case I think the problem is that the screen absolute coordinates are used, which are not equal to the coordinates relative to the React Root view and they extend beyond those screen "edges":

(just assuming things here)

Here's another case of the bounds animation failing, this is a regular phone without any "safe areas", just the 24px statusbar:

recorded-3550743286521.MP4

Here the image seems to be a bit higher up than it should be, looks to me as if it were exactly twice the statusbar moved up. Maybe there's a - STATUS_BAR_HEIGHT somewhere where it should be a + STATUS_BAR_HEIGHT instead, just assuming things again. You can also see that after I fast-refresh the view, it goes into the correct place, so it has to be an issue with the RNN SET.

Maybe statusBar: { drawBehind: true } or statusBar: { visible: false } is not respected here?

Have you read the Contributing Guidelines on issues?

yea

To Reproduce

1. Create Shared Element Transition
2. Try it on phones with Safe Areas, or in my case just a regular Huawai P10

Expected behavior

It should exactly animate to the bounds of the target react view

Actual Behavior

it animates to some wrong coordinates.

Your Environment

• React Native Navigation version: 6f7c2d9
• React Native version: 0.64.1
• Platform(s) (iOS, Android, or both?): Android
• Device info (Simulator/Device? OS version? Debug/Release?): all

[mrousavy]

cc @guyca @swabbass

[swabbass]

@mrousavy Thx dude for the report, and sorry for the late response :].
Actually, I have no such device (edge) to reproduce and check, but can you check this PR if it fixes your issue? at least left/right edges.

[guyca]

@mrousavy wasn't this fixed by Hanno and me two weeks ago? 🤔

[mrousavy]

Yes, I believe that's the fix: 642b429

Wonder what's happening now, I'll check

[mrousavy]

@swabbass which PR is it ? did you merge it already?

[swabbass]

Yes, I believe that's the fix: 642b429

Wonder what's happening now, I'll check

@mrousavy can we close this issue? :] (the PR I was talking about is merged to master, contains a couple of SET bug fixes )