[iOS] waitForRender on showModal breaks modal layout and dismiss

[FransTwisk]

🐛 Bug Report

On iOS, using waitForRender on showModal results in broken modal rendering, and when dismissing a modal it results in a black screen on previous (root) stack.

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

1. Use following on (global) navigator options:

  animations: {
    showModal: {
      waitForRender: false,
    },
  },

2. Open modal in iOS
3. Dismiss modal in iOS

Expected behavior

Using waitForRender: true on showModal should not affect the (default) layout of modals on iOS, and should just return to previous stack, instead or rendering a black screen when dismissing.

Actual Behavior

1. Modal is rendered sticked to top instead of bottom of screen.

2. When dismissing, the previous stack is not rendered, but black.

Your Environment

• React Native Navigation version: 7.16.0
• React Native version: 0.64.2
• Platform(s) (iOS, Android, or both?): iOS
• Device info (Simulator/Device? OS version? Debug/Release?): Simulator & Device, iOS 12 (probably others as well), Debug & Release

[yogevbd]

@FransTwisk Could you please reproduce it in the playground app? I tried with no luck

[tomhicks]

I just replicated exactly this behaviour.

      animations: {
        push: {
          waitForRender: true,
        },
        // showModal: {
        //   waitForRender: true,
        // },
      },

The comments fix everything!

Edit: I upgraded from 7.8.4 where this wasn't an issue

[wsliaw]

this issue fixed in 7.17.1, but waitForRender seems broken