Support launch storyboards as splash screens on iOS#1165
Merged
Conversation
|
Does this have anything to do with why I'm getting a blank white screen with my fatal errors? Seems like something to do with storyboard files. https://stackoverflow.com/questions/46206139/error-screen-with-white-background |
Collaborator
chilinh
added a commit
to chilinh/react-native-navigation
that referenced
this pull request
Jan 15, 2018
* r_master: fixed storyboard crash Support launch storyboards as splash screens on iOS (wix#1165) Force UiManager to measure SideMenu Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple's docs recommend the use of storyboards as launch screens:
This PR changes
-[RCCManager showSplashScreen]so that it checks first for a launch storyboard, then for a launch xib, and then for launch images. If none of these are found, it defaults to showing a view controller with a white background.UIView.self.#pragma markand movedgetBridgeandgetAppWindowto the top of the file.In my tests, this works beautifully. I would be interested to know if it still works correctly for images and xibs.
Any feedback much appreciated.