Remove createJSModules @override marker - RN 0.47 compatibility#1628
Merged
Conversation
Collaborator
|
Thanks |
timxyz
pushed a commit
to 3sidedcube/react-native-navigation
that referenced
this pull request
Aug 3, 2017
* master: (95 commits) Update styling-the-navigator.md Support statusBarTextColorScheme on Android Remove depreciated createJSModules @OverRide marker (wix#1628) Fix crash with scrollViewDidEndDecelerating and RCTTextView (wix#1630) Center title when setting title dynamically update docs for iOS drawer animations in top-level-api section (wix#1619) walk-around for React-Native bug with multiple RCTRootView (wix#1618) Send initial screen appear event after it's displayed Send visibility events for TopTabs screens Update screen-api.md Push screen from drawer in example app Update top-level-api.md (Added forgotten styles) (wix#1600) Update readme for title Image on top bar (wix#1599) Update screen-api.md fix iOS crash on showController (wix#1588) Add show modal button to SideMenu Fix crash when SideMenu closes Add onKeyUp event to ActivityCallbacks Update screen-api.md Update top-level-api.md ... # Conflicts: # android/app/src/main/java/com/reactnativenavigation/animation/VisibilityAnimator.java # ios/Helpers/RCTHelpers.h # ios/Helpers/RCTHelpers.m # ios/RCCViewController.m
timxyz
pushed a commit
to 3sidedcube/react-native-navigation
that referenced
this pull request
Aug 3, 2017
* develop: (96 commits) Update styling-the-navigator.md Support statusBarTextColorScheme on Android Remove depreciated createJSModules @OverRide marker (wix#1628) Fix crash with scrollViewDidEndDecelerating and RCTTextView (wix#1630) Center title when setting title dynamically update docs for iOS drawer animations in top-level-api section (wix#1619) walk-around for React-Native bug with multiple RCTRootView (wix#1618) Send initial screen appear event after it's displayed Send visibility events for TopTabs screens Update screen-api.md Push screen from drawer in example app Update top-level-api.md (Added forgotten styles) (wix#1600) Update readme for title Image on top bar (wix#1599) Update screen-api.md fix iOS crash on showController (wix#1588) Add show modal button to SideMenu Fix crash when SideMenu closes Add onKeyUp event to ActivityCallbacks Update screen-api.md Update top-level-api.md ...
junedomingo
pushed a commit
to junedomingo/react-native-navigation
that referenced
this pull request
Sep 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createJSModulesis now not required on Android from RN 0.47. This is backwards compatible according to my tests.