Fixed dismissAllModals for iOS#2093
Closed
seosgithub wants to merge 4 commits into
Closed
Conversation
…s like the tab bar that it shouldn't have. Related isssues #284 #1598 #418
seosgithub
force-pushed
the
ios-dismissAllModals-fix
branch
from
3574c28 to
6e68e84
Compare
|
when will this be published on npm? |
|
could this PR be merged? |
Contributor
|
I too would love to see this merged. It would be more useful for handling deep links that come into the app and we don't want to keep track of how many modal layers deep we are on the off chance that there are two displayed. |
Author
|
We've been using this in production for a few weeks without any mishaps. |
Contributor
|
Solved in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed dismissAllModals for iOS - Previously it would unregister things like the tab bar that it shouldn't have. #284 #1598 #418