Support re-enabling top bar elevation#2229
Merged
Merged
Conversation
When disabling elevation by setting topBarElevationShadowEnabled to false, this commit allows to re-enable it by setting the same property to true. Elevation was previously disabled by using setOutlineProvider(null), with ViewOutlineProvider being an Android 5.0+ object responsible for determining how views draw their outline. To allow re-enabling elevation, we keep our original ViewOutlineProvider and restore it when elevation is enabled again.
chilinh
added a commit
to chilinh/react-native-navigation
that referenced
this pull request
Jan 2, 2018
* r_master: fixes wix#2353 Update third-party-libraries-support.md [docs] Update minimum officially supported RN version Don't override LightBox ReactRootView id Update example app to rn51 Revert "fix images name (wix#2451)" Revert "Upgrade example proj to rn51 (wix#2452)" Upgrade example proj to rn51 (wix#2452) fix images name (wix#2451) fixed buttons text attributes revert on press Fix a uncommented line (wix#2226) Support re-enabling top bar elevation (wix#2229) Document how to use index.js as entry point (wix#2412) Revert "Now allowing the custom nav bar to take up the whole space on iOS" (wix#2404) Improve getCurrentlyVisibleScreenId on iOS with drawers. (wix#2052) introducing navbar shadow on iOS (wix#2339) This fixes an issue with a custom title-view (which has a title and a subtitle) appearing at the left side of the nav-bar instead of the center during a transition animation: when a screen with this title-view is being pushed or when you pop back to it. (wix#2384)
krystofcelba
pushed a commit
to krystofcelba/react-native-navigation
that referenced
this pull request
Jan 4, 2018
When disabling elevation by setting topBarElevationShadowEnabled to false, this commit allows to re-enable it by setting the same property to true. Elevation was previously disabled by using setOutlineProvider(null), with ViewOutlineProvider being an Android 5.0+ object responsible for determining how views draw their outline. To allow re-enabling elevation, we keep our original ViewOutlineProvider and restore it when elevation is enabled again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When disabling elevation by setting
topBarElevationShadowEnabledtofalse, this commit allows to re-enable it by setting the same property to true.Elevation was previously disabled by using
setOutlineProvider(null), withViewOutlineProviderbeing an Android 5.0+ object responsible for determining how views draw their outline. To allow re-enabling elevation, we keep our originalViewOutlineProviderand restore it when elevation is enabled again.Tested on Android 4.4 (no elevation appears at all as designed) and Android 6.0.
Fixes #1495.