Skip to content

Resolved issues where Drawer did not work after dismissAllModals #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mckn wants to merge 2 commits into from
Closed

Resolved issues where Drawer did not work after dismissAllModals #2245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
033be01
fixed issue where drawer stopped working after dismissAll.
mckn Nov 29, 2017
2c79594
Merge branch 'master' into master
gran33 Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ios/RCCManagerModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,10 @@ -(void)dismissAllModalPresenters:(NSMutableArray*)allPresentedViewControllers re
{
counter++;

[[RCCManager sharedIntance] unregisterController:viewController];
if ([self viewControllerIsModal:viewController]) {
[[RCCManager sharedIntance] unregisterController:viewController];
}

if (viewController.presentedViewController != nil)
{
dispatch_semaphore_t dismiss_sema = dispatch_semaphore_create(0);
Expand Down
4 changes: 2 additions & 2 deletions src/deprecated/platformSpecificDeprecated.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,8 +543,8 @@ async function dismissModal(params) {
return await Modal.dismissController(params.animationType);
}

function dismissAllModals(params) {
Modal.dismissAllControllers(params.animationType);
async function dismissAllModals(params) {
return await Modal.dismissAllControllers(params.animationType);
}

function showLightBox(params) {
Expand Down