async await for push and showModal#2270
Merged
Merged
Conversation
Contributor
|
please resolve conflicts |
DanielZlotin
suggested changes
Dec 19, 2017
| RNNNavigationOptions* options = [[RNNNavigationOptions alloc] initWithDict:node.data[@"navigationOptions"]]; | ||
| NSString* containerId = node.nodeId; | ||
| return [[RNNRootViewController alloc] initWithName:name withOptions:options withContainerId:containerId rootViewCreator:_creator eventEmitter:_eventEmitter]; | ||
| return [[RNNRootViewController alloc] initWithName:name withOptions:options withContainerId:containerId rootViewCreator:_creator eventEmitter:_eventEmitter customTransitionDict:customTransition]; |
Contributor
There was a problem hiding this comment.
please refactor and use a typed object instead of a dictionary, all the way from command handler down to the animation manager
|
|
||
| @implementation RNNAnimator | ||
|
|
||
| - (instancetype)initWithAnimationsDictionary:(NSDictionary *)animationsDic { |
Contributor
There was a problem hiding this comment.
this can be easily unit-tested in native (XCtests). I'll merge the changes, plz open a separate issue on it and assign yourself
DanielZlotin
approved these changes
Dec 20, 2017
chilinh
added a commit
to chilinh/react-native-navigation
that referenced
this pull request
Dec 21, 2017
* r_v2: (75 commits) Topbar (wix#2382) V2 background Image options (wix#2375) async await for push and showModal (wix#2270) Temporarily disable failing e2e test (wix#2377) navigation bars e2e with testIDs (wix#2365) V2 drawUnder for topBar and bottomTabs (wix#2376) xcpretty was swallowing test errors back to normal back to normal try fix travis Setup TopTabs with ViewPager (wix#2373) try fix travis try fix travis Further work on TopTabs and some refactoring (wix#2362) try fix travis try fix travis try fix travis try fix travis try fix travis another try ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.