Skip to content

V2 navigation bars e2e #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yogevbd merged 4 commits into from
Dec 19, 2017
Merged

V2 navigation bars e2e #2365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b2d008
navigation bars e2e with testIDs
yogevbd Dec 17, 2017
3a57e7b
Merge branch 'v2' into v2-navBarsE2E
yogevbd Dec 18, 2017
af8be80
Merge branch 'v2' into v2-navBarsE2E
yogevbd Dec 19, 2017
f68872b
Merge branch 'v2' into v2-navBarsE2E
DanielZlotin Dec 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions e2e/ScreenStyle.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ describe('screen style', () => {

it('declare a navigationOptions on container component', async () => {
await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
await expect(element(by.label('Static Title').and(by.type('UILabel')))).toBeVisible();
await expect(element(by.label('Static Title'))).toBeVisible();
});

it('change title on container component', async () => {
await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
await expect(element(by.label('Static Title').and(by.type('UILabel')))).toBeVisible();
await expect(element(by.label('Static Title'))).toBeVisible();
await elementById(testIDs.DYNAMIC_OPTIONS_BUTTON).tap();
await expect(element(by.label('Dynamic Title').and(by.type('UILabel')))).toBeVisible();
await expect(element(by.label('Dynamic Title'))).toBeVisible();
});

it('set dynamic options with valid options will do something and not crash', async () => {
Expand All @@ -30,20 +30,20 @@ describe('screen style', () => {
it('hides Tab Bar when pressing on Hide Top Bar and shows it when pressing on Show Top Bar', async () => {
await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
await elementById(testIDs.HIDE_TOP_BAR_BUTTON).tap();
await expect(element(by.type('UINavigationBar'))).toBeNotVisible();
await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeNotVisible();
await elementById(testIDs.SHOW_TOP_BAR_BUTTON).tap();
await expect(element(by.type('UINavigationBar'))).toBeVisible();
await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeVisible();
});

it('hides topBar onScroll down and shows it on scroll up', async () => {
await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
await elementById(testIDs.SCROLLVIEW_SCREEN_BUTTON).tap();
await elementById(testIDs.TOGGLE_TOP_BAR_HIDE_ON_SCROLL).tap();
await expect(element(by.type('UINavigationBar'))).toBeVisible();
await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeVisible();
await element(by.id(testIDs.SCROLLVIEW_ELEMENT)).swipe('up', 'fast');
await expect(element(by.type('UINavigationBar'))).toBeNotVisible();
await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeNotVisible();
await element(by.id(testIDs.SCROLLVIEW_ELEMENT)).swipe('down', 'fast');
await expect(element(by.type('UINavigationBar'))).toBeVisible();
await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeVisible();
});

it('makes topBar transparent and opaque', async () => {
Expand All @@ -61,18 +61,18 @@ describe('screen style', () => {
});

it('hide Tab Bar', async () => {
await elementByLabel('Switch to tab based app').tap();
await expect(element(by.type('UITabBar'))).toBeVisible();
await elementByLabel('Hide Tab Bar').tap();
await expect(element(by.type('UITabBar'))).toBeNotVisible();
await elementById(testIDs.TAB_BASED_APP_BUTTON).tap();
await expect(elementById(testIDs.BOTTOM_TABS_ELEMENT)).toBeVisible();
await elementById(testIDs.HIDE_BOTTOM_TABS_BUTTON).tap();
await expect(elementById(testIDs.BOTTOM_TABS_ELEMENT)).toBeNotVisible();
});

it('show Tab Bar', async () => {
await elementByLabel('Switch to tab based app').tap();
await elementByLabel('Hide Tab Bar').tap();
await expect(element(by.type('UITabBar'))).toBeNotVisible();
await elementByLabel('Show Tab Bar').tap();
await expect(element(by.type('UITabBar'))).toBeVisible();
await elementById(testIDs.TAB_BASED_APP_BUTTON).tap();
await elementById(testIDs.HIDE_BOTTOM_TABS_BUTTON).tap();
await expect(elementById(testIDs.BOTTOM_TABS_ELEMENT)).toBeNotVisible();
await elementById(testIDs.SHOW_BOTTOM_TABS_BUTTON).tap();
await expect(elementById(testIDs.BOTTOM_TABS_ELEMENT)).toBeVisible();
});

it('side menu visibility - left', async () => {
Expand Down
3 changes: 2 additions & 1 deletion playground/src/containers/OptionsScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ class OptionsScreen extends Component {
largeTitle: false,
hidden: false,
textFontSize: 16,
textFontFamily: 'HelveticaNeue-Italic'
textFontFamily: 'HelveticaNeue-Italic',
testID: testIDs.TOP_BAR_ELEMENT
},
rightButtons: [{
id: BUTTON_ONE,
Expand Down
11 changes: 9 additions & 2 deletions playground/src/containers/TextScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ const Navigation = require('react-native-navigation');
const testIDs = require('../testIDs');

class TextScreen extends Component {
static get navigationOptions() {
return {
bottomTabs: {
testID: testIDs.BOTTOM_TABS_ELEMENT
}
};
}

render() {
return (
Expand All @@ -16,8 +23,8 @@ class TextScreen extends Component {
<Text style={styles.footer}>{`this.props.containerId = ${this.props.containerId}`}</Text>
<Button title={'Set Tab Badge'} testID={testIDs.SET_TAB_BADGE_BUTTON} onPress={() => this.onButtonPress()} />
<Button title={'Switch To Tab 2'} testID={testIDs.SWITCH_SECOND_TAB_BUTTON} onPress={() => this.onClickSwitchToTab()} />
<Button title="Hide Tab Bar" onPress={() => this.hideTabBar(true)} />
<Button title="Show Tab Bar" onPress={() => this.hideTabBar(false)} />
<Button title="Hide Tab Bar" testID={testIDs.HIDE_BOTTOM_TABS_BUTTON} onPress={() => this.hideTabBar(true)} />
<Button title="Show Tab Bar" testID={testIDs.SHOW_BOTTOM_TABS_BUTTON} onPress={() => this.hideTabBar(false)} />
<Button title="Show Left Side Menu" testID={testIDs.SHOW_LEFT_SIDE_MENU_BUTTON} onPress={() => this.showSideMenu('left')} />
<Button title="Show Right Side Menu" testID={testIDs.SHOW_RIGHT_SIDE_MENU_BUTTON} onPress={() => this.showSideMenu('right')} />
</View>
Expand Down
8 changes: 6 additions & 2 deletions playground/src/testIDs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,18 @@ module.exports = {
SHOW_RIGHT_SIDE_MENU_BUTTON: `SHOW_RIGHT_SIDE_MENU_BUTTON`,
HIDE_LEFT_SIDE_MENU_BUTTON: `HIDE_LEFT_SIDE_MENU_BUTTON`,
HIDE_RIGHT_SIDE_MENU_BUTTON: `HIDE_RIGHT_SIDE_MENU_BUTTON`,
HIDE_BOTTOM_TABS_BUTTON: `HIDE_BOTTOM_TABS_BUTTON`,
SHOW_BOTTOM_TABS_BUTTON: `SHOW_BOTTOM_TABS_BUTTON`,

// Elements
SCROLLVIEW_ELEMENT: `SCROLLVIEW_ELEMENT`,
CENTERED_TEXT_HEADER: `CENTERED_TEXT_HEADER`,
BOTTOM_TABS_ELEMENT: `BOTTOM_TABS_ELEMENT`,
TOP_BAR_ELEMENT: `TOP_BAR_ELEMENT`,

// Headers
WELCOME_SCREEN_HEADER: `WELCOME_SCREEN_HEADER`,
PUSHED_SCREEN_HEADER: `PUSHED_SCREEN_HEADER`,
OPTIONS_SCREEN_HEADER: `OPTIONS_SCREEN_HEADER`,
MODAL_SCREEN: `MODAL_SCREEN`
MODAL_SCREEN: `MODAL_SCREEN`,
CENTERED_TEXT_HEADER: `CENTERED_TEXT_HEADER`
};