Skip to content

Added optional fixedWidth property to the Android side menu#2380

Merged
guyca merged 3 commits into
wix:masterfrom
SudoPlz:fix/androidSideWidth
Dec 20, 2017
Merged

Added optional fixedWidth property to the Android side menu#2380
guyca merged 3 commits into
wix:masterfrom
SudoPlz:fix/androidSideWidth

Conversation

@SudoPlz
Copy link
Copy Markdown
Contributor

@SudoPlz SudoPlz commented Dec 20, 2017 •
edited
Loading

Example:

Navigation.startSingleScreenApp({
    screen: 'Welcome'
    drawer: {
      left: {
        screen: 'SideMenu',
        fixedWidth: 400,
      },
    },
  });
}

@guyca
Copy link
Copy Markdown
Collaborator

guyca commented Dec 20, 2017

Looks good! Can you please add it to the docs? https://wix.github.io/react-native-navigation/#/top-level-api

@SudoPlz
Copy link
Copy Markdown
Contributor Author

SudoPlz commented Dec 20, 2017

For sure, let me make the changes.

@SudoPlz
Copy link
Copy Markdown
Contributor Author

SudoPlz commented Dec 20, 2017

Done

@guyca guyca merged commit 4fe8652 into wix:master Dec 20, 2017
chilinh added a commit to chilinh/react-native-navigation that referenced this pull request Dec 21, 2017
@chilinh
Merge branch 'r_master'
479fbda 
* r_master:
  Now allowing the custom nav bar to take up the whole space on iOS (wix#2306)
  Fix formatting of code block in installation-ios (wix#2356)
  Added optional fixedWidth property to the Android side menu (wix#2380)
  await startApp
  on activity resumed (wix#2370)
thanhzusu pushed a commit to thanhzusu/react-native-navigation that referenced this pull request Dec 21, 2017
Merge branch 'master' into thanhzusu-patch-for-3km
a7cead8 
* master:
  Now allowing the custom nav bar to take up the whole space on iOS (wix#2306)
  Fix formatting of code block in installation-ios (wix#2356)
  Added optional fixedWidth property to the Android side menu (wix#2380)
  await startApp
  on activity resumed (wix#2370)
  fixed toggle tabs bug (wix#2369)
  Add paddingTop to android ToolBar. (wix#2266)
  [Android] TopTabs font family (wix#2342)
  Ensure correct spelling of commandType (wix#2246)
  Add unregisterForPreviewingWithContext (wix#2239)
  Fix rn 0.50 repeated calls to onMeasure. (wix#2261)
  [Android] Support for transparent statusbar with current screen rendered behind it (wix#2274)
  Fix NPE when activity is relaunched on changing font size of the phone (wix#2319)
  Missed comma (wix#2305)
  Add commandType param to props which indicates if a screen is displayed using push or modal
  Find textual buttons in TitleBar by text instead of content description
  Add a toString implementation to StyleParams Color (wix#2313)
krystofcelba pushed a commit to krystofcelba/react-native-navigation that referenced this pull request Jan 4, 2018
@SudoPlz @krystofcelba
Added optional fixedWidth property to the Android side menu (wix#2380)
d8c48f4 
* v1.1.314 [ci skip]

* Added optional fixedWidth property to the Android side menu

- Fixes: https://github.com/wix/react-native-navigation/issues/510

* Added fixedWidth drawer param to te top-level-api doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SudoPlz @guyca @DanielZlotin