Skip to content

Add support for prefersLargeTitles in iOS 11 #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yogevbd merged 1 commit into from
Jan 25, 2018
Merged

Add support for prefersLargeTitles in iOS 11 #2593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/styling-the-navigator.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ this.props.navigator.setStyle({
preferredContentSize: { width: 500, height: 500 } // Sets the preferred size for the view controller’s view.
modalPresentationStyle: 'formSheet' // Sets the presentation style for modally presented view controllers. Supported styles are: 'formSheet', 'pageSheet', 'overFullScreen', 'overCurrentContext' and 'fullScreen'.

largeTitle: false, // Sets the nav bar title to be in the larger iOS 11 style

// Android only
navigationBarColor: '#000000', // change the background color of the bottom native navigation bar.
navBarTitleTextCentered: true, // default: false. centers the title.
Expand Down
17 changes: 17 additions & 0 deletions ios/RCCViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,23 @@ -(void)setStyleOnAppearForViewController:(UIViewController*)viewController appea
self.navigationItem.titleView.clipsToBounds = YES;
}
}

if (@available(iOS 11.0, *)) {
if ([self.navigationController.navigationBar respondsToSelector:@selector(setPrefersLargeTitles:)]) {
NSNumber *prefersLargeTitles = self.navigatorStyle[@"largeTitle"];
if (prefersLargeTitles) {
if ([prefersLargeTitles boolValue]) {
self.navigationController.navigationBar.prefersLargeTitles = YES;
self.navigationItem.largeTitleDisplayMode = UINavigationItemLargeTitleDisplayModeAlways;
} else {
self.navigationItem.largeTitleDisplayMode = UINavigationItemLargeTitleDisplayModeNever;
}
} else {
self.navigationController.navigationBar.prefersLargeTitles = NO;
self.navigationItem.largeTitleDisplayMode = UINavigationItemLargeTitleDisplayModeNever;
}
}
}
}


Expand Down