Skip to content

Fix EmptyStackException#2746

Merged
guyca merged 1 commit into
wix:masterfrom
varungupta85:fix-emptystackexception
Feb 18, 2018
Merged

Fix EmptyStackException#2746
guyca merged 1 commit into
wix:masterfrom
varungupta85:fix-emptystackexception

Conversation

@varungupta85
Copy link
Copy Markdown
Contributor

@varungupta85 varungupta85 commented Feb 18, 2018

Fix the below EmptyStackException

java.util.EmptyStackException: null
    at java.util.Stack.peek(Stack.java:57)
    at com.reactnativenavigation.screens.ScreenStack.peek(ScreenStack.java:240)
    at com.reactnativenavigation.layouts.SingleScreenLayout.getCurrentScreen(SingleScreenLayout.java:323)
    at com.reactnativenavigation.views.SnackbarAndFabContainer$1.run(SnackbarAndFabContainer.java:70)
    at com.reactnativenavigation.views.FloatingActionButtonCoordinator$2.onAnimationEnd(FloatingActionButtonCoordinator.java:78)
    at com.reactnativenavigation.views.FloatingActionButtonAnimator$2.onAnimationEnd(FloatingActionButtonAnimator.java:96)
    at android.view.ViewPropertyAnimator$AnimatorEventListener.onAnimationEnd(ViewPropertyAnimator.java:1135)
    at android.animation.ValueAnimator.endAnimation(ValueAnimator.java:1239)
    at android.animation.ValueAnimator$AnimationHandler.doAnimationFrame(ValueAnimator.java:766)
    at android.animation.ValueAnimator$AnimationHandler$1.run(ValueAnimator.java:801)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:894)
    at android.view.Choreographer.doCallbacks(Choreographer.java:696)
    at android.view.Choreographer.doFrame(Choreographer.java:628)
    at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:880)
    at android.os.Handler.handleCallback(Handler.java:822)
    at android.os.Handler.dispatchMessage(Handler.java:104)
    at android.os.Looper.loop(Looper.java:207)
    at android.app.ActivityThread.main(ActivityThread.java:5811)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:791)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:681)

@varungupta85
Copy link
Copy Markdown
Contributor Author

varungupta85 commented Feb 18, 2018

Fixes #2049

@guyca guyca merged commit 674a43d into wix:master Feb 18, 2018
chilinh added a commit to chilinh/react-native-navigation that referenced this pull request Feb 21, 2018
@chilinh
Merge branch 'r_master'
bc7dac8 
* r_master:
  [iOS] Allow set view controllers to be called with multiple components (wix#2247)
  Document subtitle parameter for screen push (wix#2735)
  Fix EmptyStackException (wix#2746)
  Reject promise if push fails
  Set titleBarSubTitleTextCentered as navigator style for android (wix#2611)
  Send bottomTabSelected event by tab index
  Send bottomTabSelectedEvent before switching tab
  Fix the json format
  Revert "Delay onDisplay until react finishes layout cycle"
  Throw exception when calling startTabBasedApp with zero tabs
  Update broken links (wix#2677)
  Update example app to RN 0.53
  Delay onDisplay until react finishes layout cycle
  Update README.md
  [Android] Add backwards compatible support for react-native 0.52.0 (wix#2580)
  fix wix#2616 (wix#2638)
  Added requiresMainQueueSetup to prevent warning and future side-effects on RCCManagerModule (wix#1983)
  Inset adjustment behavior should be automatic
  launchArgs format
  Remove unneeded code

# Conflicts:
#	android/app/src/main/java/com/reactnativenavigation/react/JsDevReloadListenerReplacer.java
thanhzusu pushed a commit to thanhzusu/react-native-navigation that referenced this pull request Feb 28, 2018
Merge branch 'master' into thanhzusu-patch-for-3km
9d81f95 
* master: (88 commits)
  try rebuild in ci
  Closes wix#2777
  Re: Now allowing the custom nav bar to take up the whole space on iOS (wix#2620)
  Fix flickering modal on Android
  Apply title in resetTo (wix#2787)
  Save props in singleScreenApp
  fixes large titles (wix#2775)
  fix tests
  Update build tools version
  Set layout style after modal dismiss
  deep stack passProps fix
  save additional screens passProps
  deep stack for startTabBasedApp and startSingleScreenApp (wix#2770)
  Added ability to specify font size for tab bar labels on Android (wix#2754)
  [Android] Add ability to start app with deep stack (wix#2761)
  [iOS] Allow set view controllers to be called with multiple components (wix#2247)
  Document subtitle parameter for screen push (wix#2735)
  Fix EmptyStackException (wix#2746)
  Reject promise if push fails
  Set titleBarSubTitleTextCentered as navigator style for android (wix#2611)
  ...

# Conflicts:
#	android/app/src/main/java/com/reactnativenavigation/params/ScreenParams.java
#	android/app/src/main/java/com/reactnativenavigation/views/LightBox.java
@steverob
Copy link
Copy Markdown

steverob commented May 18, 2018

@varungupta85 I'm still seeing this issue..

Caused by java.util.EmptyStackException
       at java.util.Stack.peek(Stack.java:102)
       at com.reactnativenavigation.screens.ScreenStack.peek(ScreenStack.java:245)
       at com.reactnativenavigation.layouts.BottomTabsLayout.getCurrentScreen(BottomTabsLayout.java:346)
       at com.reactnativenavigation.controllers.NavigationActivity.getCurrentlyVisibleEventId(NavigationActivity.java:495)
       at com.reactnativenavigation.controllers.NavigationActivity.onResume(NavigationActivity.java:140)
       at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1270)
       at android.app.Activity.performResume(Activity.java:6977)
       at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3455)
       at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3518)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1566)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:163)
       at android.app.ActivityThread.main(ActivityThread.java:6205)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:904)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:794)

timxyz pushed a commit to 3sidedcube/react-native-navigation that referenced this pull request May 23, 2018
Merge branch 'develop' into feature/pixie-v1.0b2
8322773 
* develop: (340 commits)
  Makes sure subtitle text is tinted by navigation bar style
  Re: Now allowing the custom nav bar to take up the whole space on iOS (wix#2620)
  Fix flickering modal on Android
  Apply title in resetTo (wix#2787)
  Save props in singleScreenApp
  fixes large titles (wix#2775)
  fix tests
  Update build tools version
  Set layout style after modal dismiss
  deep stack passProps fix
  save additional screens passProps
  deep stack for startTabBasedApp and startSingleScreenApp (wix#2770)
  Added ability to specify font size for tab bar labels on Android (wix#2754)
  [Android] Add ability to start app with deep stack (wix#2761)
  [iOS] Allow set view controllers to be called with multiple components (wix#2247)
  Document subtitle parameter for screen push (wix#2735)
  Fix EmptyStackException (wix#2746)
  Reject promise if push fails
  Set titleBarSubTitleTextCentered as navigator style for android (wix#2611)
  Send bottomTabSelected event by tab index
  ...

# Conflicts:
#	android/app/src/main/java/com/reactnativenavigation/bridge/NavigationReactModule.java
#	android/app/src/main/java/com/reactnativenavigation/controllers/NavigationActivity.java
#	src/Navigation.js
#	src/deprecated/platformSpecificDeprecated.android.js
#	src/platformSpecific.android.js
reimertz pushed a commit to mavencook/react-native-navigation that referenced this pull request Sep 14, 2018
@varungupta85
Fix EmptyStackException (wix#2746)
b7958ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@varungupta85 @steverob @guyca