Re: Re: Now allowing the custom nav bar to take up the whole space on iOS #2947
Closed
SudoPlz wants to merge 14 commits into
Closed
Re: Re: Now allowing the custom nav bar to take up the whole space on iOS #2947SudoPlz wants to merge 14 commits into
SudoPlz wants to merge 14 commits into
Conversation
1. Rename `DevCommandsHandlerProxy` to `DevHelperProxy` so it reflects the changes in RN. See facebook/react-native@d19afc7 . 2. Add few comments to show which code is used on `RN >= 0.52` and which on `RN <= 0.51`.
The custom nav bar on iOS was really just a custom view applied to the title of the navigation bar. There were problems with this approach, because the navigation bar messes up the frame of the title very frequently, especially when the orientation is changing. That behaviour is accepted when the title is a label, but not when we have a custom component. With this pull request the custom nav bar component can take up the full width of the navigation bar, no matter what orientation we're at.
…reen of the example project
Support for RN 52 (before getting merged in official wix repo)
Contributor
Author
|
Closed in favour of #3129 since I want to add more features on master, and I can't wait for wix to review this. |
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the third attempt to get this merged.
The first attempt was #2306 it got merged, and then it got reverted.
The second time (#2620) it got merged again but it's not in master yet and I have no idea why.
I added normal buttons to the custom top bar screen on the example project, as a show case and in order to prove that this pr works fine.
The CustomTitleView is NOT positioned above the left or right buttons as you can see here:
Please get this sorted out, or if you don't think that's a good PR please let me know why so that I can fix it.
Thank you