Skip to content

Fixed passing props in Android to match how iOS did it #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yedidyak wants to merge 1 commit into from
Closed

Fixed passing props in Android to match how iOS did it #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 34 additions & 46 deletions example-redux/src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,28 +39,28 @@ export default class App {
screen: {
screen: 'example.LoginScreen',
title: 'Login',
navigatorStyle: {},
passProps: {
str: 'This is a prop passed in \'startSingleScreenApp()\'!',
obj: {
str: 'This is a prop passed in an object!',
arr: [
{
str: 'This is a prop in an object in an array in an object!'
}
navigatorStyle: {}
},
passProps: {
str: 'This is a prop passed in \'startSingleScreenApp()\'!',
obj: {
str: 'This is a prop passed in an object!',
arr: [
{
str: 'This is a prop in an object in an array in an object!'
}
],
arr2: [
[
'array of strings',
'with two strings'
],
arr2: [
[
'array of strings',
'with two strings'
],
[
1, 2, 3
]
[
1, 2, 3
]
},
num: 1234
}
]
},
num: 1234
}
});
return;
Expand All @@ -73,41 +73,29 @@ export default class App {
icon: require('../img/one.png'),
selectedIcon: require('../img/one_selected.png'),
title: 'Screen One',
navigatorStyle: {},
passProps: {
str: 'This is a prop passed in \'startTabBasedApp\'!',
obj: {
str: 'This is a prop passed in an object!',
arr: [
{
str: 'This is a prop in an object in an array in an object!'
}
]
},
num: 1234
}
navigatorStyle: {}
},
{
label: 'Two',
screen: 'example.SecondTabScreen',
icon: require('../img/two.png'),
selectedIcon: require('../img/two_selected.png'),
title: 'Screen Two',
navigatorStyle: {},
passProps: {
str: 'This is a prop passed in \'startTabBasedApp\'!',
obj: {
str: 'This is a prop passed in an object!',
arr: [
{
str: 'This is a prop in an object in an array in an object!'
}
]
},
num: 1234
}
navigatorStyle: {}
}
],
passProps: {
str: 'This is a prop passed in \'startTabBasedApp\'!',
obj: {
str: 'This is a prop passed in an object!',
arr: [
{
str: 'This is a prop in an object in an array in an object!'
}
]
},
num: 1234
},
animationType: 'slide-down',
title: 'Redux Example'
});
Expand Down
3 changes: 3 additions & 0 deletions src/platformSpecific.android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ function startSingleScreenApp(params) {
addNavigatorParams(screen);
addNavigatorButtons(screen);
addNavigationStyleParams(screen);
screen.passProps = params.passProps;
RctActivity.startSingleScreenApp(screen);
}

Expand All @@ -35,11 +36,13 @@ function startTabBasedApp(params) {
addNavigatorParams(tab, null, idx);
addNavigatorButtons(tab);
addNavigationStyleParams(tab);
tab.screen.passProps = params.passProps;
});

RctActivity.startTabBasedApp(params.tabs);
}


function navigatorPush(navigator, params) {
addNavigatorParams(params, navigator);
addNavigatorButtons(params);
Expand Down