Skip to content

Support DynamicColorIOS #7248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yogevbd merged 2 commits into from
Sep 5, 2021
Merged

Support DynamicColorIOS #7248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09e7205
Support DynamicColorIOS
yogevbd Sep 4, 2021
2caeda6
Update OptionsProcessor.ts
yogevbd Sep 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/src/commands/OptionsProcessor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { AssetService } from '../adapters/AssetResolver';
import { Deprecations } from './Deprecations';
import { CommandName } from '../interfaces/CommandName';
import { OptionsProcessor as Processor } from '../interfaces/Processors';
import { Platform } from 'react-native';
import { DynamicColorIOS, Platform } from 'react-native';

describe('navigation options', () => {
let uut: OptionsProcessor;
Expand Down Expand Up @@ -574,6 +574,17 @@ describe('navigation options', () => {
},
});
});

it('supports DynamicColorIOS', () => {
const options: Options = {
topBar: { background: { color: DynamicColorIOS({ light: 'red', dark: 'blue' }) } },
};

uut.processOptions(options, CommandName.SetRoot);
expect(options).toEqual({
topBar: { background: { color: { dynamic: { light: 0xffff0000, dark: 0xff0000ff } } } },
});
});
});
});

Expand Down
6 changes: 6 additions & 0 deletions lib/src/commands/OptionsProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ export class OptionsProcessor {
if ('semantic' in value || 'resource_paths' in value) {
options[key] = value;
return;
} else if ('dynamic' in value) {
for (let keyColor in value.dynamic) {
newColorObj[keyColor] = this.colorService.toNativeColor(value.dynamic[keyColor]);
}

options[key] = newColorObj;
} else {
for (let keyColor in value) {
newColorObj[keyColor] = this.colorService.toNativeColor(value[keyColor]);
Expand Down