Skip to content

Fix playground reanimated animations #7375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yogevbd merged 1 commit into from
Nov 25, 2021
Merged

Fix playground reanimated animations #7375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions playground/src/screens/sharedElementCarDealer/CarCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { BlurView } from '@react-native-community/blur';
import React, { useCallback, useEffect, useMemo, useRef } from 'react';
import { StyleSheet, Text, Dimensions, ViewProps, Platform } from 'react-native';
import Reanimated, { Easing, useValue } from 'react-native-reanimated';
import Reanimated, { EasingNode, useValue } from 'react-native-reanimated';
import FastImage from 'react-native-fast-image';
import { CarItem } from '../../assets/cars';
import { hexToRgba } from '../../commons/Colors';
Expand Down Expand Up @@ -44,7 +44,7 @@ export default function CarCard({
Reanimated.timing(textContainerOpacity, {
toValue: 0,
duration: 300,
easing: Easing.linear,
easing: EasingNode.linear,
}).start();
}, [onCarPressed, textContainerOpacity]);
const onFocus = useCallback(() => {
Expand All @@ -53,7 +53,7 @@ export default function CarCard({
Reanimated.timing(textContainerOpacity, {
toValue: 1,
duration: 300,
easing: Easing.linear,
easing: EasingNode.linear,
}).start();
}
}, [textContainerOpacity]);
Expand Down
6 changes: 3 additions & 3 deletions playground/src/screens/sharedElementCarDealer/CarDetailsScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
} from 'react-native-navigation';
import { CarItem } from '../../assets/cars';
import FastImage from 'react-native-fast-image';
import Reanimated, { Easing, useValue } from 'react-native-reanimated';
import Reanimated, { EasingNode, useValue } from 'react-native-reanimated';
import DismissableView from './DismissableView';
import useDismissGesture from './useDismissGesture';
import { buildFullScreenSharedElementAnimations, SET_DURATION } from './Constants';
Expand Down Expand Up @@ -47,7 +47,7 @@ const CarDetailsScreen: NavigationFunctionComponent<Props> = ({ car, componentId
);
const headerY = useMemo(
() =>
Reanimated.interpolate(scrollY, {
Reanimated.interpolateNode(scrollY, {
inputRange: [0, HEADER_HEIGHT],
outputRange: [0, -HEADER_HEIGHT],
extrapolateLeft: Reanimated.Extrapolate.CLAMP,
Expand Down Expand Up @@ -83,7 +83,7 @@ const CarDetailsScreen: NavigationFunctionComponent<Props> = ({ car, componentId
Reanimated.timing(dismissGesture.controlsOpacity, {
toValue: 1,
duration: 300,
easing: Easing.linear,
easing: EasingNode.linear,
}).start();
}, SET_DURATION);
}, [dismissGesture.controlsOpacity]);
Expand Down
4 changes: 2 additions & 2 deletions playground/src/screens/sharedElementCarDealer/CarStoryScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
OptionsModalTransitionStyle,
} from 'react-native-navigation';
import { CarItem } from '../../assets/cars';
import Reanimated, { Easing } from 'react-native-reanimated';
import Reanimated, { EasingNode } from 'react-native-reanimated';
import DismissableView from './DismissableView';
import useDismissGesture from './useDismissGesture';
import { SET_DURATION } from './Constants';
Expand Down Expand Up @@ -38,7 +38,7 @@ const CarStoryScreen: NavigationFunctionComponent<Props> = ({ car, componentId }
Reanimated.timing(dismissGesture.controlsOpacity, {
toValue: 1,
duration: 300,
easing: Easing.linear,
easing: EasingNode.linear,
}).start();
}, SET_DURATION);
}, [dismissGesture.controlsOpacity]);
Expand Down
8 changes: 4 additions & 4 deletions playground/src/screens/sharedElementCarDealer/useDismissGesture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ export default function useDismissGesture(navigateBack: () => void): DismissGest
const enableGesture = useValue<0 | 1>(1); // Overrides gestureHandler.state to not trigger State.END cond() block when already released and navigating back

const cardBorderRadius = useMemo(() => {
return Reanimated.interpolate(dismissAnimationProgress, {
return Reanimated.interpolateNode(dismissAnimationProgress, {
inputRange: [0, 1],
outputRange: [0, 30],
extrapolate: Extrapolate.CLAMP,
});
}, [dismissAnimationProgress]);
const viewScale = useMemo(() => {
return Reanimated.interpolate(dismissAnimationProgress, {
return Reanimated.interpolateNode(dismissAnimationProgress, {
inputRange: [0, 1],
outputRange: [1, 0.8],
extrapolate: Extrapolate.CLAMP,
Expand All @@ -61,14 +61,14 @@ export default function useDismissGesture(navigateBack: () => void): DismissGest
cond(eq(gestureHandler.state, State.ACTIVE), [
set(
dismissAnimationProgress,
Reanimated.interpolate(gestureHandler.translation.y, {
Reanimated.interpolateNode(gestureHandler.translation.y, {
inputRange: [0, SCREEN_HEIGHT * 0.2],
outputRange: [0, 1],
})
),
set(
controlsOpacity,
Reanimated.interpolate(gestureHandler.translation.y, {
Reanimated.interpolateNode(gestureHandler.translation.y, {
inputRange: [0, SCREEN_HEIGHT * 0.1, SCREEN_HEIGHT * 0.2],
outputRange: [1, 0, 0],
})
Expand Down