Skip to content

Revert "Revert "Added support for the predictive back gesture on Android#7653

Merged
yogevbd merged 2 commits into
masterfrom
androidBackGesture
Dec 12, 2022
Merged

Revert "Revert "Added support for the predictive back gesture on Android#7653
yogevbd merged 2 commits into
masterfrom
androidBackGesture

Conversation

@yogevbd

@yogevbd yogevbd commented Dec 11, 2022

Copy link
Copy Markdown
Collaborator

This reverts commit 2d247ce.

@yogevbd yogevbd merged commit 6a615bb into master Dec 12, 2022
@yogevbd yogevbd deleted the androidBackGesture branch December 12, 2022 09:47
@vovkasm

vovkasm commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

Sorry for late interruption, but why we corrupt files outside of project dir? I mean this change https://github.com/wix/react-native-navigation/pull/7653/files#diff-9319e9c2a463c6a4c862ec0a8695cb4dd9a859bbfd508bf81e8938685e92d2efR170

@lyswhut

lyswhut commented Dec 22, 2022

Copy link
Copy Markdown

This PR caused v7.30.6 to fail to build on Windows platforms, where the following changes needed to be applied to work:

-def command = sdkDir.absolutePath + "/cmdline-tools/latest/bin/sdkmanager build-tools;" + buildToolsVersion
+def command = sdkDir.absolutePath + "/cmdline-tools/latest/bin/sdkmanager.bat build-tools;" + buildToolsVersion

@yogevbd

yogevbd commented Dec 22, 2022

Copy link
Copy Markdown
Collaborator Author

Sorry for late interruption, but why we corrupt files outside of project dir? I mean this change https://github.com/wix/react-native-navigation/pull/7653/files#diff-9319e9c2a463c6a4c862ec0a8695cb4dd9a859bbfd508bf81e8938685e92d2efR170

@evgeni-wix do we really need this?

@yogevbd

yogevbd commented Dec 22, 2022

Copy link
Copy Markdown
Collaborator Author

This PR caused v7.30.6 to fail to build on Windows platforms, where the following changes needed to be applied to work:

-def command = sdkDir.absolutePath + "/cmdline-tools/latest/bin/sdkmanager build-tools;" + buildToolsVersion
+def command = sdkDir.absolutePath + "/cmdline-tools/latest/bin/sdkmanager.bat build-tools;" + buildToolsVersion

@lyswhut addressed here

@lyswhut

lyswhut commented Dec 22, 2022

Copy link
Copy Markdown

In v7.30.6, the system back key on the android platform seems to be invalid, and the back key cannot back to the desktop after clicking the back key. The last working version is v7.30.3

@evgeni-wix

Copy link
Copy Markdown
Contributor

Sorry for late interruption, but why we corrupt files outside of project dir? I mean this change https://github.com/wix/react-native-navigation/pull/7653/files#diff-9319e9c2a463c6a4c862ec0a8695cb4dd9a859bbfd508bf81e8938685e92d2efR170

@evgeni-wix do we really need this?

@yogevbd It was really needed for build tools 33. Since the build tools version has been changed to 31, I suppose it can be removed. Need to check though.

@vovkasm

vovkasm commented Dec 23, 2022

Copy link
Copy Markdown
Contributor

I removed this code in our fork and nothing bad happened with build tools 33 (sorry, we actually using build tools 31) (at least on linux and macos platforms). Moreover it fixed the build in our CI in which external connectivity very restricted (most external repos accessible only through cached proxy).
Though, we did not tried to build RNN itself, only whole app.

SudoPlz pushed a commit that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants