Feat/rn76 oldarch by gosha212 · Pull Request #7967 · wix/react-native-navigation

gosha212 · 2025-01-29T15:19:32Z

As preparation for new arch, the project was upgraded to support RN 76 without the new arch.
New arch is still in progress
#7941

Fixed ios pod file

This reverts commit 1ed449b.

retyui · 2025-02-02T11:53:00Z

I'm so happy, FINALLY!

d4vidi · 2025-02-02T17:03:59Z

I'm so happy, FINALLY!

Lol thanks, I'll review this personally within days

d4vidi

Well looks great but it definitely looks like this change is not backwards compatible. Let's consider the limitations together.

d4vidi

Please check (and fix?) for RN73

Moises-dev08 · 2025-02-05T20:14:19Z

We are stuck with building our current new project due to this issue. 🙏 Hope it can be merged soon 🙏
thank you for you hard work guys!! 👏 @gosha212 👏

Yash2711 · 2025-02-06T06:17:07Z

Same here, we are also stuck upgrading our project to 0.76.X. Hope this gets merged soon.

gosha212 · 2025-02-06T08:11:39Z

@Yash2711 @Moises-dev08 I'm releasing an RC version for you. It is basically ready. We are still testing backward compatibility to RN 73.
Here is the build: https://buildkite.com/wix-mobile-oss/react-native-navigation/builds/1513#0194da4c-3f1a-4935-9be7-fb7d3ae1493f

This is the version: 7.41.0-rc01

Moises-dev08 · 2025-02-06T19:24:24Z

@gosha212 it seems that the release failed

gosha212 · 2025-02-06T20:15:11Z

@Moises-dev08 you can take 7.42.0

Moises-dev08 · 2025-02-06T21:23:22Z

@gosha212 I'm not able to do it. The latest is v7.0.14..

retyui · 2025-02-06T21:31:41Z

@Moises-dev08 you used incorrect package

@react-navigation/native - completely different library

retyui · 2025-02-06T21:33:06Z

https://www.npmjs.com/package/react-native-navigation?activeTab=versions

Moises-dev08 · 2025-02-06T21:42:01Z

Ups my bad. Thank you my friend!

tarouboy · 2025-02-18T12:03:58Z

Trying out version 8.0.0
with RN 0.76.7

App able to build, however when app launches return this error:
Native module RNNBridgeModule tried to override NavigationModule. Check the getPackages() method in MainApplication.java, it might be that module is being created twice. If this was your intention, set canOverrideExistingModule=true. This error may also be present if the package is present only once in getPackages() but is also automatically added later during build time by autolinking. Try removing the existing entry and rebuild.

This is the code inside playground/MainApplication.java

@Override
public List<ReactPackage> getPackages() {
    ArrayList<ReactPackage> packages = new PackageList(this).getPackages();
    packages.add(new NavigationPackage(mReactNativeHost));
    return packages;
}

After changing it to:

@Override
public List<ReactPackage> getPackages() {
    return new PackageList(this).getPackages();
}

The error resolved and the app able to run.

* Apply color animations on tab-switching (Android-only) (#7975) * Update package.json version to 7.44.0 [buildkite skip] * Fix npm registry and recreate package-lock.json (#7987) * fix(sdk35): Apply inset over bottom-tabs (#7991) * Update package.json version to 7.45.0 [buildkite skip] * Revert "Feat/rn76 oldarch (#7967)" (#8003) * Update package.json version to 7.46.0 [buildkite skip] * Mocked side-menus - support (#8017) * Update package.json version to 7.47.0 [buildkite skip] * Support drawer menus opening as overlay instead of pushing content in ios (#7986) * Update package.json version to 7.48.0 [buildkite skip] * Patch-fix some recent side-menu overlay mode changes (#8039) * Introduce options to make a floating bottom-tabs (Android) (#8064) * Update package.json version to 7.49.0 [buildkite skip] * fix: top bar buttons disappeared when lock screen then unlock sreen (#8053) (#8076) Co-authored-by: NormanWangEndeavor <145947285+NormanWangEndeavor@users.noreply.github.com> * Update package.json version to 7.50.0 [buildkite skip] * Back-compat edge2edge for standard layout, incl. drawBehind * merge master into me * first config to get it running * bottom bar edge2edge complete? * statusbar e2e * cleanup * backward compatiblility * final touches * Fix yarn registry to use public npmjs.org instead of internal wixpress Made-with: Cursor * #8080 * conflict fixes * snapshot updates * more updates * update e2e android * snapsot update * documentation * added * codex fixes * enableEdgeToEdge() is now the decision hook — override it to control when edge-to-edge activates activateEdgeToEdge() is the action method — it does both EdgeToEdge.enable(this) and SystemUiUtils.activateEdgeToEdge(), so it's impossible to enable Android edge-to-edge without also setting RNN's internal flag The docs now show activateEdgeToEdge() in the override example instead of EdgeToEdge.enable(this) --------- Co-authored-by: d4vidi <amit.d4vidi@gmail.com> Co-authored-by: mobileoss <mobileoss@wix.com> Co-authored-by: Liat Netach <60575762+liatnetach@users.noreply.github.com> Co-authored-by: Georgy Steshin <gosha212@gmail.com> Co-authored-by: NormanWangEndeavor <145947285+NormanWangEndeavor@users.noreply.github.com>

gosha212 added 21 commits January 27, 2025 16:41

Upgraded android to work with rn 77

2a776db

Upgraded to the latest version of detox

100dd5b

Added react types.

c742e3b

Fixed ios pod file

Updated pod filke

aee806a

Fixed es lint error

cacd4fe

Upgraded reanimated

419eed1

Fixed ios build

6f2ca4c

Fixed ios build

fd97ab2

Fixed one test in android

5dcf7c6

Fixed android tests

cc25411

Fixed android unit tests

e036898

Fixed android unit tests

24144b1

Fixed android tests

68cce81

Fixed mocked tests

534dbb7

Downgrade to RN 76

e719a90

support ios

ff9ed27

fixed android screenshot

7183b68

fixed android screenshot

550a73f

Reimplemented missing bar style in iOS

81f1eb6

Reimplemented missing bar style in iOS

2000684

Fixed ios bar styling

6b32776

gosha212 added Infrastructure type: accepted/enhancement labels Jan 30, 2025

gosha212 added 3 commits January 30, 2025 13:25

Removed unused library

560f994

Upgraded roboletric to run on updated sdk

1ed449b

Revert "Upgraded roboletric to run on updated sdk"

a199c01

This reverts commit 1ed449b.

This was referenced Jan 30, 2025

fix(ios): rct convert bar style #7950

Closed

fix(Android): Kotlin build issues with RN 0.75.3 #7913

Closed

d4vidi self-assigned this Feb 2, 2025

retyui approved these changes Feb 2, 2025

View reviewed changes

d4vidi requested changes Feb 3, 2025

View reviewed changes

gosha212 and others added 3 commits February 3, 2025 15:47

Fixes for PR

7beb52c

Merge branch 'master' into feat/rn76-oldarch

b815cab

Fixed ios build

960085e

d4vidi requested changes Feb 3, 2025

View reviewed changes

d4vidi previously approved these changes Feb 6, 2025

View reviewed changes

Test commit

465b63c

gosha212 dismissed d4vidi’s stale review via 465b63c February 6, 2025 14:10

gosha212 merged commit 375636d into master Feb 6, 2025

gosha212 deleted the feat/rn76-oldarch branch February 6, 2025 14:11

d4vidi added a commit that referenced this pull request Apr 17, 2025

Revert "Feat/rn76 oldarch (#7967)"

af91529

d4vidi added a commit that referenced this pull request Apr 17, 2025

Revert "Feat/rn76 oldarch (#7967)" (#8003)

4509824

NormanWangEndeavor pushed a commit to NormanWangEndeavor/react-native-navigation that referenced this pull request Feb 26, 2026

Feat/rn76 oldarch (wix#7967)

b4afb47

Conversation

gosha212 commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

retyui commented Feb 2, 2025

Uh oh!

d4vidi commented Feb 2, 2025

Uh oh!

d4vidi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

d4vidi left a comment

Choose a reason for hiding this comment

Uh oh!

Moises-dev08 commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yash2711 commented Feb 6, 2025

Uh oh!

gosha212 commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Moises-dev08 commented Feb 6, 2025

Uh oh!

gosha212 commented Feb 6, 2025

Uh oh!

Moises-dev08 commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

retyui commented Feb 6, 2025

Uh oh!

retyui commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Moises-dev08 commented Feb 6, 2025

Uh oh!

tarouboy commented Feb 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gosha212 commented Jan 29, 2025 •

edited

Loading

Moises-dev08 commented Feb 5, 2025 •

edited

Loading

gosha212 commented Feb 6, 2025 •

edited

Loading

Moises-dev08 commented Feb 6, 2025 •

edited

Loading

retyui commented Feb 6, 2025 •

edited

Loading