Android style fixes#83
Merged
Merged
Conversation
added 2 commits
June 23, 2016 23:31
| RctActivity.navigatorPopToRoot({ | ||
| navigatorID: navigator.navigatorID, | ||
| animated: !(params.animated !== false) | ||
| animated: !(params.animated === false) |
Collaborator
There was a problem hiding this comment.
Can this conditional be changed to params.animated === true?
Author
|
That depends on what the default behavior should be. If we're defaulting to false then the === true makes sense, since any non-true value would return false. With my change the value defaults to true for any non-false (but still falsey) value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update ensures navigator styles are applied on screen changes. It also merges the base styles with screen-specific styles as to allow default values that can be overridden.