[RN78][public] TextField - no default preset shown in the screen#3946
Merged
Conversation
Made-with: Cursor
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
MIchaelZablianov
requested review from
M-i-k-e-l
and removed request for
lidord-wix
MIchaelZablianov
changed the title
M-i-k-e-l
reviewed
Mar 9, 2026
M-i-k-e-l
left a comment
M-i-k-e-l
left a comment
Contributor
There was a problem hiding this comment.
Nice!
Looking at this again I found this line:
TextField.defaultProps = {preset: TextField.presets.UNDERLINE, ...TextField.defaultProps};
Which when removed gives the same outcome in master.
So this solution seems valid, please remove the relevant line(s).
Also, please remove the [, ] in the changelog
M-i-k-e-l
added a commit
that referenced
this pull request
May 17, 2026
* RN 0.78 - basic upgrade * Infra/v9 codemod (#3899) * npx codemod@latest react/19/migration-recipe * npx types-react-codemod@latest preset-19 . * Infra/v9 prop types (#3900) * Remove DemoScreen (unused) * Remove prop-types * Remove @types/prop-types * Infra/v9 default props (#3901) * Remove unneeded defaultProps * defaultProps on asBaseComponent * Remove defaultProps (unused af far as we can tell) * Remove DocsGenerator (unused) * Fix (most) typescript issue (#3902) * Fix (most) typescript issue * Infra/v9 tests (#3903) * Fix button and update @testing-library/react-native version * Remove unsupported modifiers methods, add docs and fix tests The old TextField was the only usage of the removed methods and it was only used by MaskedInput which is deprecated * V9 - fixes (#3904) * npx codemod@latest react/19/migration-recipe * npx types-react-codemod@latest preset-19 . * Remove DemoScreen (unused) * Remove prop-types * Remove @types/prop-types * Remove unneeded defaultProps * defaultProps on asBaseComponent * Remove defaultProps (unused af far as we can tell) * Remove DocsGenerator (unused) * Fix (most) typescript issue * Fix button and update @testing-library/react-native version * Remove unsupported modifiers methods, add docs and fix tests The old TextField was the only usage of the removed methods and it was only used by MaskedInput which is deprecated * KeyboardTrackingView - support defaultProps * Bump uilib-native version * uilib-native - fix npm package of uilib-native * Update project.pbxproj * Add check for do not merge * Remove (will be added in master) * Fix types * Checkbox - fix label's type * Update uilib-native to snapshot * "Force" defaultProps on forwardRef * Add uilib-native to the monorepo (#3923) * Monorepo - lib to uilib-native * Fix releaseNative script * More build fixes * Try adding --workspace * Revert (Try adding --workspace) * Infra/monorepo release script (#3931) * Monorepo - lib to uilib-native * Fix releaseNative script * More build fixes * Try adding --workspace * Revert (Try adding --workspace) * Unified release script for monorepo * Fix dryRun always being true * buildKiteVersion is only for release * Delete packages/uilib-native/scripts/.npmrc * Add Picker to the doc (dialog migration) * [RN78][public] TextField - no default preset shown in the screen (#3946) * fix: set default TextField preset to UNDERLINE in demo screen Made-with: Cursor * applied comments * Demo's configurations - remove unused TextField import * Marquee - move to Incubator * Marquee - move to Incubator - docs * Update Jest configuration to use setupFilesAfterEnv instead of setupFiles * Update version to 9 --------- Co-authored-by: MIchaelZablianov <michaelza@wix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After investigating the issue - 4965, it came out that the issue is only in the demo screen, due to how Switch (SegmentedControl) is implemented.
undefinedtoTextField.presets.UNDERLINEso the demo launches with the underline style by default.Changelog
Additional info
ticket 4965