Add the ability to toggle the reception of palette synchronizations#4137
Conversation
Contributor
|
FYI palette, not pallet. |
Member
@felddy please avoid force-pushing github while you have a PR open. |
Contributor
Author
Doh! 🤦♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds the ability to toggle the reception of palette synchronizations on a node.
receiveNotificationPaletteSupported issues:
💭 Motivation and context
I want to keep the palette synchronized across all nodes, but need to preserve the effect on some of them.
🧪 Testing
Tested on four ESP32 nodes. Verified palettes can be synchronized without effects, and effects can be synchronized without palettes.
📷 Screenshots (if appropriate)
✅ Pre-approval checklist