Skip to content

Phase 3: SHA512 integrity check and closing the final FIPS requirements gaps#10281

Open
kaleb-himes wants to merge 1 commit into
wolfSSL:masterfrom
kaleb-himes:PQ-FS-2026-Part3-SecurityReview
Open

Phase 3: SHA512 integrity check and closing the final FIPS requirements gaps#10281
kaleb-himes wants to merge 1 commit into
wolfSSL:masterfrom
kaleb-himes:PQ-FS-2026-Part3-SecurityReview

Conversation

@kaleb-himes

Copy link
Copy Markdown
Contributor

Description

Please describe the scope of the fix or feature addition.

Fixes zd#

Testing

How did you test?

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@kaleb-himes kaleb-himes force-pushed the PQ-FS-2026-Part3-SecurityReview branch 3 times, most recently from 8923ea5 to 9af5352 Compare April 22, 2026 22:51
@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

gcc-arm-cortex-m3

  • FLASH: .text +32 B (+0.0%, 120,937 B / 262,144 B, total: 46% used)

gcc-arm-cortex-m4

  • FLASH: .rodata.CSWTCH.1 +20 B, .rodata.str1.1 +214 B, .text +64 B (+0.2%, 198,488 B / 262,144 B, total: 76% used)

gcc-arm-cortex-m4-baremetal

  • FLASH: .text +64 B (+0.1%, 65,867 B / 262,144 B, total: 25% used)

gcc-arm-cortex-m4-crypto-only

  • FLASH: .rodata.CSWTCH.1 +20 B, .rodata.str1.1 +214 B (+0.1%, 173,528 B / 262,144 B, total: 66% used)

gcc-arm-cortex-m4-dtls13

  • FLASH: .text +64 B (+0.0%, 179,352 B / 1,048,576 B, total: 17% used)

gcc-arm-cortex-m4-openssl-compat

  • FLASH: .rodata +232 B, .text +64 B (+0.0%, 765,972 B / 1,048,576 B, total: 73% used)

gcc-arm-cortex-m4-pkcs7

  • FLASH: .rodata.CSWTCH.1 +20 B, .rodata.str1.1 +214 B, .text +64 B (+0.1%, 210,971 B / 262,144 B, total: 80% used)

gcc-arm-cortex-m4-pq

  • FLASH: .rodata +228 B, .text +192 B (+0.2%, 277,308 B / 1,048,576 B, total: 26% used)

gcc-arm-cortex-m4-rsa-only

  • FLASH: .rodata +224 B, .text +64 B (+0.1%, 322,392 B / 1,048,576 B, total: 31% used)

gcc-arm-cortex-m4-tls13

  • FLASH: .rodata.CSWTCH.1 +20 B, .rodata.str1.1 +214 B, .text +64 B (+0.1%, 234,442 B / 262,144 B, total: 89% used)

gcc-arm-cortex-m7

  • FLASH: .rodata.CSWTCH.1 +20 B, .rodata.str1.1 +214 B, .text +64 B (+0.2%, 198,488 B / 262,144 B, total: 76% used)

gcc-arm-cortex-m7-pq

  • FLASH: .rodata +228 B, .text +192 B (+0.2%, 277,884 B / 1,048,576 B, total: 27% used)

gcc-arm-cortex-m7-tls13

  • FLASH: .rodata.CSWTCH.1 +20 B, .rodata.str1.1 +214 B (+0.1%, 234,442 B / 262,144 B, total: 89% used)

linuxkm-pie

  • Data: __patchable_function_entries +8 B (+0.0%, 24,184 B)

linuxkm-standard

  • Data: __patchable_function_entries +16 B (+0.0%, 45,888 B)

stm32-sim-stm32h753

@kaleb-himes kaleb-himes changed the title Pq fs 2026 part3 security review Phase 3: SHA512 integrity check and closing the final FIPS requirements gaps Apr 23, 2026
@kaleb-himes kaleb-himes force-pushed the PQ-FS-2026-Part3-SecurityReview branch 3 times, most recently from a43af0f to 7c0c87a Compare April 29, 2026 14:06

@Frauschi Frauschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found one small possible memory usage optimization. Otherwise LGTM

Comment thread wolfcrypt/src/wc_slhdsa.c Outdated
@kaleb-himes kaleb-himes force-pushed the PQ-FS-2026-Part3-SecurityReview branch 9 times, most recently from e3f56b8 to 29c714f Compare May 1, 2026 20:03
@kaleb-himes kaleb-himes force-pushed the PQ-FS-2026-Part3-SecurityReview branch 4 times, most recently from b883766 to a6681e2 Compare May 27, 2026 22:14
@kaleb-himes

Copy link
Copy Markdown
Contributor Author

retest this please

@kaleb-himes kaleb-himes force-pushed the PQ-FS-2026-Part3-SecurityReview branch from a6681e2 to 588e7a0 Compare June 8, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants