Skip to content

Implementing missing macros to openssl compatibility layer #10520

Open
Roy-Carter wants to merge 2 commits into
wolfSSL:masterfrom
Roy-Carter:feature/extending_comp_layer
Open

Implementing missing macros to openssl compatibility layer #10520
Roy-Carter wants to merge 2 commits into
wolfSSL:masterfrom
Roy-Carter:feature/extending_comp_layer

Conversation

@Roy-Carter

Copy link
Copy Markdown
Contributor

Description

Implementing as part of migration to wolfssl
SSL_set_ciphersuites
X509_add1_ext_i2d
sk_GENERAL_NAME_new_null
EC_KEY_oct2key

Testing

unitests to each functionality added

Checklist

  • [ *] added tests
  • [ *] updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@wolfSSL-Bot

Copy link
Copy Markdown

Can one of the admins verify this patch?

@Roy-Carter

Copy link
Copy Markdown
Contributor Author

@julek-wolfssl second part of the functions i've implemented , split the PR's for clarity of checks .

@Roy-Carter Roy-Carter force-pushed the feature/extending_comp_layer branch from 54ef2e4 to 413e8ac Compare May 24, 2026 11:04
@Roy-Carter

Copy link
Copy Markdown
Contributor Author

@dgarske errors seemed related to master diff. both tests worked for me locally , I rebased , can we re-run workflow?

@Roy-Carter Roy-Carter force-pushed the feature/extending_comp_layer branch from 413e8ac to 62138a2 Compare May 29, 2026 12:42
@Roy-Carter

Copy link
Copy Markdown
Contributor Author

@julek-wolfssl @dgarske I've rebased to master , seems related to new changes added .

@dgarske

dgarske commented May 29, 2026

Copy link
Copy Markdown
Member

Jenkins okay to test

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the OpenSSL compatibility layer with aliases and implementations for several missing APIs used during migration to wolfSSL.

Changes:

  • Adds compatibility mappings for SSL_set_ciphersuites, X509_add1_ext_i2d, sk_GENERAL_NAME_new_null, and EC_KEY_oct2key.
  • Implements wolfSSL_X509_add1_ext_i2d and wolfSSL_EC_KEY_oct2key.
  • Adds unit tests covering the new compatibility APIs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
wolfssl/ssl.h Declares the new X509 extension helper.
wolfssl/openssl/ssl.h Adds OpenSSL compatibility macros for SSL, X509, and GENERAL_NAME APIs.
wolfssl/openssl/ec.h Declares and maps EC_KEY_oct2key.
src/x509.c Implements wolfSSL_X509_add1_ext_i2d.
src/pk_ec.c Implements wolfSSL_EC_KEY_oct2key.
tests/api.c Adds API tests for the new compatibility additions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/x509.c Outdated
Comment thread src/x509.c
Comment thread tests/api.c
Comment thread tests/api.c

@julek-wolfssl julek-wolfssl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Roy-Carter please address copilot review. Thanks.

@Roy-Carter Roy-Carter force-pushed the feature/extending_comp_layer branch from 62138a2 to 653ec68 Compare June 7, 2026 07:53
@Roy-Carter

Copy link
Copy Markdown
Contributor Author

@julek-wolfssl can we re-run workflow ?

@Roy-Carter Roy-Carter requested a review from julek-wolfssl June 7, 2026 07:54
@julek-wolfssl

Copy link
Copy Markdown
Member
$ ./autogen.sh && ./configure --enable-all && make check
...
FAILURES:
   871: test_wolfSSL_X509_add_ext
   929: test_wolfSSL_X509_add1_ext_i2d_flags

 End API Tests
 Failed/Skipped/Passed/All: 2/182/1432/1616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants