OpenSSL compat with ML-DSA by kojo1 · Pull Request #10962 · wolfSSL/wolfssl

kojo1 · 2026-07-21T21:35:01Z

Description

wolfSSL_PEM_read_bio_PrivateKey
wolfSSL_PEM_read_PrivateKey
wolfSSL_d2i_PrivateKey, wolfSSL_d2i_PublicKey
wolfSSL_X509_sign
wolfSSL_X509_REQ_sign
wolfSSL_X509_set_pubkey

Fixes zd#22151

Testing

Added test_wolfSSL_PEM_PrivateKey_mldsa
Added ML-DSA cases in test_wolfSSL_X509_set_pubkey

Checklist

added tests
updated/added doxygen
updated appropriate READMEs
Updated manual and documentation

github-actions · 2026-07-21T21:49:49Z

MemBrowse Memory Report

gcc-arm-cortex-m4

FLASH: .rodata.CSWTCH.1 +8 B, .rodata.str1.1 +122 B (+0.1%, 201,239 B / 262,144 B, total: 77% used)

gcc-arm-cortex-m4-crypto-only

FLASH: .rodata.CSWTCH.1 +8 B, .rodata.str1.1 +122 B (+0.1%, 175,250 B / 262,144 B, total: 67% used)

gcc-arm-cortex-m4-openssl-compat

FLASH: .rodata +128 B, .text +512 B (+0.1%, 773,484 B / 1,048,576 B, total: 74% used)

gcc-arm-cortex-m4-pkcs7

FLASH: .rodata.CSWTCH.1 +8 B, .rodata.str1.1 +122 B (+0.1%, 214,038 B / 262,144 B, total: 82% used)

gcc-arm-cortex-m4-pq

FLASH: .rodata +128 B (+0.0%, 281,216 B / 1,048,576 B, total: 27% used)

gcc-arm-cortex-m4-rsa-only

FLASH: .rodata +136 B (+0.0%, 327,328 B / 1,048,576 B, total: 31% used)

gcc-arm-cortex-m4-tls13

FLASH: .rodata.CSWTCH.1 +8 B, .rodata.str1.1 +122 B (+0.1%, 237,385 B / 262,144 B, total: 91% used)

gcc-arm-cortex-m7

FLASH: .rodata.CSWTCH.1 +8 B, .rodata.str1.1 +122 B (+0.1%, 201,239 B / 262,144 B, total: 77% used)

gcc-arm-cortex-m7-pq

FLASH: .rodata +128 B (+0.0%, 281,792 B / 1,048,576 B, total: 27% used)

gcc-arm-cortex-m7-tls13

FLASH: .rodata.CSWTCH.1 +8 B, .rodata.str1.1 +122 B (+0.1%, 237,449 B / 262,144 B, total: 91% used)

linuxkm-standard

Data: __patchable_function_entries -32 B (-0.1%, 49,192 B)

stm32-sim-stm32h753

FLASH: .text +132 B (+0.1%, 185,816 B / 2,097,152 B, total: 9% used)
No memory changes detected for:
gcc-arm-cortex-m0plus
gcc-arm-cortex-m3
gcc-arm-cortex-m4-baremetal
gcc-arm-cortex-m4-dtls13
gcc-arm-cortex-m4-min-ecc
gcc-arm-cortex-m4-sp-math
gcc-arm-cortex-m4-tls12
linuxkm-pie

Frauschi

🐺 Skoll Code Review

Overall recommendation: APPROVE
Findings: 4 total — 3 posted, 2 skipped

Posted findings

[High] ML-DSA private key decode in X509 sign/set_pubkey missing PRIVATE_KEY_UNLOCK bracket (fails under FIPS) — src/x509.c:12827, src/x509.c:16508
[Medium] WC_MAX_X509_GEN increase puts 20 KB on the stack in wolfSSL_X509_REQ_sign for all key types — src/x509.c:12953-12962, 16922-16923
[Medium] wolfSSL_X509_REQ_sign changes lack ML-DSA test coverage — src/x509.c:16918-16950

Skipped findings

[Low] fnames[] can become a zero-length array if all ML-DSA levels are disabled
[Medium] WC_MAX_X509_GEN increase puts 20 KB on the stack in wolfSSL_X509_REQ_sign for all key types

Review generated by Skoll via Claude/Codex

kojo1 · 2026-07-24T21:51:32Z

lack ML-DSA test coverage

Add ML-DSA test coverage for X509_REQ_sign

missing PRIVATE_KEY_UNLOCK bracket

PRIVATE_KEY_UNLOCK to X509 sign/set_pubkey

WC_MAX_X509_GEN increase puts 20 KB on the stack

Dynamic buff size based on expected cert size

Frauschi · 2026-07-27T07:56:01Z

@kojo1 The CAVP self test failure is legit (undefined references during linking).

Frauschi

🐺 Skoll Code Review

Overall recommendation: APPROVE
Findings: 19 total — 13 posted, 6 skipped

Posted findings

[High] d2iTryMlDsaKey silently returns a stale EVP_PKEY when the caller reuses an existing key object — wolfcrypt/src/evp_pk.c:1086-1096
[Medium] DER buffer sizing ignores the subject public key, only the signing key — src/x509.c:12961-12974
[Medium] ML-DSA signing still requires a valid digest; comment claims md is ignored — src/x509.c:12274-12277
[Medium] Preprocessor gating mismatch: sigTypeFromPKEY accepts ML-DSA in builds where resign_cert cannot sign — src/x509.c:12274
[Medium] MlDsaKey reused across a failed PrivateKeyDecode without Free/Init in X509_set_pubkey — src/x509.c:16519-16542
[Medium] d2i_evp_pkey PKCS#8 algorithm cross-check not extended for ML-DSA — wolfcrypt/src/evp_pk.c:1548-1553
[Medium] Test coverage limited to ML-DSA-44; the riskiest new paths are untested — tests/api/test_x509.c:1071-1128
[Medium] wolfSSL_X509_set_pubkey stores the standard ML-DSA OID for FIPS204-draft keys; the WC_ML_DSA_*_DRAFT cases are unreachable — src/x509.c:16546-16590
[Low] New ML-DSA code uses MlDsaKey and mixed heap hints, unlike the rest of x509.c — src/x509.c:12786
[Low] WC_MAX_X509_GEN_MLDSA is an unrelated magic number to WC_MAX_X509_GEN — src/x509.c:12962-12974
[Low] X509_GEN_BUF_SZ sizes the DER buffer from the signing key, ignoring an ML-DSA subject public key — src/x509.c:12961-12974
[Low] New ML-DSA code uses legacy-only LEVEL2/3/5 spellings, breaking WOLFSSL_NO_DILITHIUM_LEGACY_NAMES builds — src/x509.c:12279-12295
[Info] ML-DSA key object reused across a failed private-key decode and a public-key decode without re-init — src/x509.c:16527-16545

Skipped findings

[Medium] WC_DECLARE_VAR/WC_ALLOC_VAR_EX abstraction dropped in X509_REQ_sign
[Low] ML-DSA level-to-OID mapping duplicated three times; four-macro guard repeated four times
[Low] Test guards: zero-length array risk and missing NO_SHA256 condition
[Info] New test entry breaks the backslash alignment of TEST_X509_DECLS
[Info] ML-DSA private key DER newly persisted in EVP_PKEY.pkey.ptr, which is freed without ForceZero
[Info] X509_GEN_BUF_SZ evaluates its argument twice and is never #undef'd

Review generated by Skoll via Claude/Codex

Frauschi

🐺 Skoll Code Review

Overall recommendation: REQUEST_CHANGES
Findings: 9 total — 8 posted, 1 skipped

Posted findings

[Medium] X509_set_pubkey() fails for ML-DSA private keys that carry no seed and no embedded public key — src/x509.c:16598
[Medium] Uninitialized MlDsaKey / WC_RNG are freed unconditionally when an earlier Expect short-circuits — tests/api/test_ossl_x509_pk.c:488
[Medium] Double XFCLOSE on the same XFILE: the f = XBADFILE reset is missing after the second close — tests/api/test_evp_pkey.c:2826
[Medium] New tests still use the legacy-only MlDsaKey typedef, breaking WOLFSSL_NO_DILITHIUM_LEGACY_NAMES builds — tests/api/test_evp_pkey.c:2846
[Medium] EVP_PKEY reuse still leaks the previously attached algorithm object, and the new test hides it — wolfcrypt/src/evp_pk.c:68
[Low] sigOID is left set to WOLFSSL_FAILURE on the X509/REQ object when the signature-type lookup fails — src/x509.c:13029
[Low] Private-key DER is released without zeroization when an EVP_PKEY is reused — wolfcrypt/src/evp_pk.c:71
[Low] A non-NULL digest is silently ignored for ML-DSA signing — src/x509.c:12206

Skipped findings

[Low] The new reuse block indexes fnames[] unconditionally, which can be a zero-length array

Review generated by Skoll via Claude/Codex

Frauschi

🐺 Skoll Code Review

Overall recommendation: COMMENT
Findings: 12 total — 3 posted, 9 skipped

Posted findings

[Medium] d2i_free_prev_key_obj() does not mirror EVP_PKEY_free() for X25519/X448/HKDF/CMAC, so those objects leak on reuse — wolfcrypt/src/evp_pk.c:44-107
[Low] Ed25519/Ed448 d2i reuse leaves the stale type and DER in place - pre-existing, but the prePopulated pattern this PR adds is the fix — wolfcrypt/src/evp_pk.c:1180
[Medium] New tests add several multi-KB stack buffers — tests/api/test_ossl_x509_pk.c:441,470,501,545; tests/api/test_evp_pkey.c:2735-2737,2790-2792

Skipped findings

[Low] The new ForceZero assumes pkey_sz describes the pkey.ptr allocation - true today, but the invariant is already broken on master (pre-existing, not a blocker)
[Medium] Unrelated deletion of WOLFSSL_MEM_FAIL_COUNT from .wolfssl_known_macro_extras
[Info] FALSE POSITIVE - X509_GEN_BUF_SZ / WOLFSSL_MLDSA_X509_SIGN definition block cannot be skipped while a consumer is compiled
[Medium] No test for the 'sigOID unchanged on rejected key/md' behavior the PR adds
[Info] ALREADY RESOLVED - non-NULL md silently ignored for ML-DSA
[Low] X509_GEN_BUF_SZ evaluates its pkey argument twice and drops it entirely in the non-ML-DSA variant
[Low] Reused EVP_PKEY is left gutted when the d2i copy allocation fails
[Low] Conditional free of pkey inside the key-file loop is hard to follow
[Info] Continuation backslash misaligned in TEST_X509_DECLS

Review generated by Skoll via Claude/Codex

Frauschi

🐺 Skoll Code Review

Overall recommendation: APPROVE
Findings: 9 total — 4 posted, 5 skipped

Posted findings

[Low] ML-DSA SPKI buffer size hand-computed instead of using MLDSA_MAX_PUB_KEY_DER_SIZE — src/x509.c:16657
[Low] Signature algorithm and signing key level derived from two independent sources without a cross-check — src/x509.c:12847-12928
[Info] Doxygen @param inserted between @return lines — wolfcrypt/src/evp_pk.c:377-382,445-450
[Info] X509_GEN_BUF_SZ macro evaluates its pkey argument twice — src/x509.c:13019-13037

Skipped findings

[Medium] EVP_PKEY reuse repopulates type/object/DER but leaves pkcs8HeaderSz and mldsaOID stale
[Medium] Non-NULL digest silently ignored for ML-DSA signing
[Low] Test gap: sigOID-preserved-on-failure and public-only ML-DSA signing key not covered
[Info] Internal build macro WOLFSSL_MLDSA_X509_SIGN sits in the public WOLFSSL_ namespace and leaks past x509.c
[Info] Unrelated ML_DSA_LEVEL2k -> ML_DSA_44k rename bundled into this PR

Review generated by Skoll via Claude/Codex

Frauschi · 2026-08-06T07:38:48Z

+                return WOLFSSL_FAILURE;
+            }
+
+            derSz = MLDSA_MAX_PUB_KEY_SIZE + MAX_ALGO_SZ + MAX_SEQ_SZ * 2;


🔵 [Low] ML-DSA SPKI buffer size hand-computed instead of using MLDSA_MAX_PUB_KEY_DER_SIZE
💡 SUGGEST convention

The new WC_EVP_PKEY_DILITHIUM case sizes the SPKI output buffer as MLDSA_MAX_PUB_KEY_SIZE + MAX_ALGO_SZ + MAX_SEQ_SZ * 2, re-deriving the DER framing overhead by hand. wolfssl/wolfcrypt/wc_mldsa.h already exports exactly this constant: MLDSA_MAX_PUB_KEY_DER_SIZE (2614 for ML-DSA-87, versus 2622 for the hand-rolled expression), and it tracks the compiled-in level set the same way. The current expression is large enough today, but it duplicates knowledge of the encoding in a second place and would silently become undersized if MAX_SEQ_SZ/MAX_ALGO_SZ ever shrank or the SPKI encoding grew. Note the same header is already reachable here (asn.h includes wc_mldsa.h under WOLFSSL_HAVE_MLDSA), and the new #define WC_MAX_X509_GEN_MLDSA a few thousand lines below repeats the same MAX_ALGO_SZ + MAX_SEQ_SZ * 2 idiom.

Suggestion:

Suggested change

derSz = MLDSA_MAX_PUB_KEY_SIZE + MAX_ALGO_SZ + MAX_SEQ_SZ * 2;

derSz = MLDSA_MAX_PUB_KEY_DER_SIZE;

p = (byte*)XMALLOC(derSz, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);

Recommendation: Use MLDSA_MAX_PUB_KEY_DER_SIZE here, and consider using it in WC_MAX_X509_GEN_MLDSA too so the SPKI overhead is defined in exactly one place.

Use MLDSA_MAX_PUB_KEY_DER_SIZE for SPKI buffers

Frauschi · 2026-08-06T07:38:48Z

+    #endif

        (void)req;
        WOLFSSL_ENTER("wolfSSL_X509_resign_cert");


🔵 [Low] Signature algorithm and signing key level derived from two independent sources without a cross-check
💡 SUGGEST bug

sigType comes from wolfSSL_sigTypeFromPKEY(), which switches on the cached pkey->mldsaOID. A few lines later type/key come from actually decoding pkey->pkey.ptr and calling mldsa_get_oid_sum() on the decoded key. Nothing checks that the two agree. If they ever diverge — e.g. mldsaOID left over from a previous decode on a reused EVP_PKEY where the OID store was skipped (see the d2i_make_pkey finding) — the emitted certificate would carry an ML-DSA-87 signatureAlgorithm over an ML-DSA-44 signature, i.e. a silently unverifiable certificate rather than an error. The decode already computes oidSum, so the assertion is free.

Suggestion:

Suggested change

WOLFSSL_ENTER("wolfSSL_X509_resign_cert");

/* sigType was derived from the cached pkey->mldsaOID; make sure

* the key we are actually signing with matches it. */

if (oidSum != WOLFSSL_ATOMIC_LOAD(pkey->mldsaOID)) {

WOLFSSL_MSG("ML-DSA key level does not match signature OID");

wc_MlDsaKey_Free(mldsa);

XFREE(mldsa, x509->heap, DYNAMIC_TYPE_MLDSA);

return WOLFSSL_FATAL_ERROR;

}

Recommendation: Add an equality check between the decoded oidSum and pkey->mldsaOID (or derive sigType from oidSum directly) so a level mismatch fails loudly instead of producing a malformed certificate.

Cross-check cached mldsaOID against decoded signing key

Frauschi · 2026-08-06T07:38:48Z

@@ -247,10 +377,12 @@ static int d2iTryEccKey(WOLFSSL_EVP_PKEY** out, const unsigned char* mem,
 * @return  1 on success.


⚪ [Info] Doxygen @param inserted between @return lines
🔧 NIT style

In both helpers the new @param [in] prePopulated block was inserted in the middle of the @return list, so the generated docs list a parameter after two return values and before a third. The equivalent addition to d2iTryMlDsaKey (line 1125) is correctly placed after the other @param entries, so the three helpers are now inconsistent with each other.

Suggestion:

Suggested change

* @return 1 on success.

* @param [in] priv 1 means private key, 0 means public key.

* @param [in] prePopulated 1 means *out already holds the input bytes

* so the d2i_make_pkey allocate/copy is skipped.

* @return 1 on success.

* @return 0 when input was recognized as this key type but object

* creation/import failed.

* @return WOLFSSL_FATAL_ERROR when input is not this key type.

Recommendation: Move the @param prePopulated block above the @return lines in both helpers, matching d2iTryMlDsaKey.

Moved the description

Frauschi · 2026-08-06T07:38:48Z

    /* able to override max size until dynamic buffer created */
    #define WC_MAX_X509_GEN 4096
 #endif
+#ifdef WOLFSSL_HAVE_MLDSA


⚪ [Info] X509_GEN_BUF_SZ macro evaluates its pkey argument twice
🔧 NIT style

X509_GEN_BUF_SZ(x509, pkey) expands pkey twice ((pkey) != NULL && (pkey)->type == ...) and dereferences (x509)->pubKey.length from a macro. Both current call sites pass plain locals so there is no side-effect hazard today, but the pattern is easy to break later, and the two-branch #ifdef duplication of the same expression is avoidable. A static int helper next to wolfssl_x509_make_der() would express the same thing with argument evaluation guarantees and a single body.

Suggestion:

Suggested change

#ifdef WOLFSSL_HAVE_MLDSA

static int x509_gen_buf_sz(const WOLFSSL_X509* x509,

const WOLFSSL_EVP_PKEY* pkey)

{

int base = WC_MAX_X509_GEN;

#ifdef WOLFSSL_HAVE_MLDSA

if ((pkey != NULL) && (pkey->type == WC_EVP_PKEY_DILITHIUM)) {

base = WC_MAX_X509_GEN_MLDSA;

}

#else

(void)pkey;

#endif

return base + (int)x509->pubKey.length;

}

Recommendation: Replace the function-like macro with a small static helper; keeps one body for both configurations and removes the double evaluation.

Replace the macro with a small static helper

kojo1 force-pushed the oss_mldsa branch from 5e8b1e3 to c71c2ba Compare July 21, 2026 22:44

kojo1 requested a review from wolfSSL-Bot July 22, 2026 22:47

Frauschi reviewed Jul 24, 2026

View reviewed changes

Comment thread src/x509.c

Frauschi assigned kojo1 Jul 24, 2026

kojo1 force-pushed the oss_mldsa branch from 7d637b2 to d9e04a7 Compare July 24, 2026 21:27

kojo1 force-pushed the oss_mldsa branch 2 times, most recently from 68dd962 to 365a9a0 Compare July 28, 2026 23:50

kojo1 requested a review from Frauschi July 29, 2026 00:28

kojiws assigned wolfSSL-Bot and kojo1 and unassigned kojo1 and wolfSSL-Bot Jul 29, 2026

Frauschi requested changes Jul 29, 2026

View reviewed changes

kojo1 requested a review from Frauschi July 31, 2026 10:23

Frauschi reviewed Jul 31, 2026

View reviewed changes

kojo1 requested a review from Frauschi August 2, 2026 11:47

Frauschi reviewed Aug 3, 2026

View reviewed changes

Comment thread wolfcrypt/src/evp_pk.c

Comment thread wolfcrypt/src/evp_pk.c

Comment thread tests/api/test_ossl_x509_pk.c Outdated

dgarske removed the request for review from wolfSSL-Bot August 3, 2026 21:46

kojo1 force-pushed the oss_mldsa branch from 554767b to 8454886 Compare August 5, 2026 05:41

kojo1 added 8 commits August 5, 2026 20:17

OpenSSL compat with ML-DSA

8c37dc3

Add ML-DSA test coverage for X509_REQ_sign

4096b43

PRIVATE_KEY_UNLOCK to X509 sign/set_pubkey

7d55fce

Dynamic buff size based on expected cert size

406a297

Explicit prePopulated flag for d2iTryMlDsaKey

f9a66fc

Size X509 gen buffer from subject public key too

bfba0a8

Allow NULL md for ML-DSA X509 signing, add test

6edb1b7

Single gate for ML-DSA X509 signing capability

b66ba13

kojo1 added 18 commits August 5, 2026 20:17

Reset MlDsaKey between decode attempts in X509_set_pubkey

37a54dd

PKCS#8 algId check and DER-only typed d2i for ML-DSA

0bbb077

Extend ML-DSA compat test coverage to all levels and untested paths

429683d

Use mldsa_get_oid_sum for draft-aware OID in X509 signing

6b81db2

Consistency cleanups in new ML-DSA X509 code

bff9cfb

Derive WC_MAX_X509_GEN_MLDSA from WC_MAX_X509_GEN

00a5cf4

Use canonical ML-DSA names in new X509/EVP code

d3e3696

Test X509_set_pubkey with seed and private-only ML-DSA keys

55b3214

Guard ML-DSA key/RNG cleanup in tests against Expect short-circuit

25b1f5e

Reset XFILE handle after every close in ML-DSA tests

d21743d

Free previous algorithm object when d2i repurposes an EVP_PKEY

2f84186

Do not store failed sigType lookup in sigOID

0fd6544

Zeroize pkey.ptr before freeing EVP_PKEY key data

d03be2c

Note deliberate md tolerance for ML-DSA X509 signing

59521d5

Fix error code check

3823ac2

Cover X25519/X448/HKDF/CMAC in d2i_free_prev_key_obj

49fbde0

Use explicit prePopulated flag in Ed25519/Ed448 d2i helpers

41c760c

Move multi-KB test buffers from stack to heap

525ddda

kojo1 force-pushed the oss_mldsa branch from ec93b48 to 4311540 Compare August 5, 2026 11:18

Use d2i_PUBKEY in Ed25519 reuse regression test

7438353

kojo1 force-pushed the oss_mldsa branch from 4311540 to 7438353 Compare August 5, 2026 22:06

kojo1 requested a review from Frauschi August 5, 2026 23:17

Frauschi reviewed Aug 6, 2026

View reviewed changes

kojo1 added 4 commits August 6, 2026 17:01

Use MLDSA_MAX_PUB_KEY_DER_SIZE for SPKI buffers

359f84a

Cross-check cached mldsaOID against decoded signing key

d34c452

Move the description

8a5b56b

Replace the macro with a small static helper

e2681cf

kojo1 requested a review from Frauschi August 6, 2026 11:11

	derSz = MLDSA_MAX_PUB_KEY_SIZE + MAX_ALGO_SZ + MAX_SEQ_SZ * 2;
	derSz = MLDSA_MAX_PUB_KEY_DER_SIZE;
	p = (byte*)XMALLOC(derSz, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);

-        WOLFSSL_ENTER("wolfSSL_X509_resign_cert");
+/* sigType was derived from the cached pkey->mldsaOID; make sure
+             * the key we are actually signing with matches it. */
+            if (oidSum != WOLFSSL_ATOMIC_LOAD(pkey->mldsaOID)) {
+                WOLFSSL_MSG("ML-DSA key level does not match signature OID");
+                wc_MlDsaKey_Free(mldsa);
+                XFREE(mldsa, x509->heap, DYNAMIC_TYPE_MLDSA);
+                return WOLFSSL_FATAL_ERROR;
+            }

		@@ -247,10 +377,12 @@ static int d2iTryEccKey(WOLFSSL_EVP_PKEY** out, const unsigned char* mem,
		* @return 1 on success.

- * @return  1 on success.
+* @param [in]      priv   1 means private key, 0 means public key.
+ * @param [in]      prePopulated  1 means *out already holds the input bytes
+ *                         so the d2i_make_pkey allocate/copy is skipped.
+ * @return  1 on success.
+ * @return  0 when input was recognized as this key type but object
+ *            creation/import failed.
+ * @return  WOLFSSL_FATAL_ERROR when input is not this key type.

-#ifdef WOLFSSL_HAVE_MLDSA
+static int x509_gen_buf_sz(const WOLFSSL_X509* x509,
+        const WOLFSSL_EVP_PKEY* pkey)
+{
+    int base = WC_MAX_X509_GEN;
+#ifdef WOLFSSL_HAVE_MLDSA
+    if ((pkey != NULL) && (pkey->type == WC_EVP_PKEY_DILITHIUM)) {
+        base = WC_MAX_X509_GEN_MLDSA;
+    }
+#else
+    (void)pkey;
+#endif
+    return base + (int)x509->pubKey.length;
+}

Uh oh!

Conversation

kojo1 commented Jul 21, 2026

Description

Testing

Checklist

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MemBrowse Memory Report

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

🐺 Skoll Code Review

Posted findings

Uh oh!

Uh oh!

kojo1 commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Frauschi commented Jul 27, 2026

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

🐺 Skoll Code Review

Posted findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

🐺 Skoll Code Review

Posted findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

🐺 Skoll Code Review

Posted findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

🐺 Skoll Code Review

Posted findings

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

github-actions Bot commented Jul 21, 2026 •

edited

Loading

kojo1 commented Jul 24, 2026 •

edited

Loading