add glibc as a runtime dep to calico packages - #3581
Merged
Conversation
Signed-off-by: Josh Wolf <josh@wolfs.io>
imjasonh
approved these changes
Jul 13, 2023
joshrwolf
enabled auto-merge
July 13, 2023 13:27
joshrwolf
added this pull request to the merge queue
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's really hard to tell which packages depend on
glibcjust based on the upstream dockerfiles (example)this covers our basis by adding it as a runtime dep to all packages, and saves us from significant work in the future if we ever decide to ship a
calico-fipsvariant