Add chroma package. - #4877
Closed
dlorenc wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Dan Lorenc <dlorenc@chainguard.dev>
dlorenc
enabled auto-merge
August 28, 2023 16:53
kaniini
suggested changes
Aug 29, 2023
kaniini
left a comment
kaniini
left a comment
Contributor
There was a problem hiding this comment.
This is pulling in vendored dependencies from PyPI, which makes it impossible for us to service CVEs in the dependencies.
The no-provides option was set to avoid conflicts at the package manager level, but that isn't the correct fix here. Instead, we need to avoid vendoring the dependencies.
Contributor
|
This Pull Request is stale because it has been open for 90 days with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Related:
Pre-review Checklist
For new package PRs only