Fix PIN Input Screen Pre-Lollipop #48
Conversation
…stener` to update the PasscodePreference Toggle and launch the setup activity.
PassGoogle Pixel on Android 7.1 with PasscodeLock Sample 1.0 FailNexus 5 on Android 4.4.2 with PasscodeLock Sample 1.0 The app is crashing on pre-Lollipop devices and emulators when tapping the "Enable lock" row or switch. Unfortunately, the monitor is not showing any exception or stack trace. |
Weird. I've a device with 4.4 and worked fine. Will try tomorrow on emulators then. |
|
@theck13 - Thanks for the testing. Will ping you again, once I resolved the issues. |
…eLock-Android into issue/43-PIN-Input-Screen-Not-Shown-pre-lollipop
…thout using the compatLibrary - `android:background="?android:attr/selectableItemBackgroundBorderless`
|
Hey @theck13 - The problem was in the XML file that defines the keyboard layout. (Actually in the definition of the style of the pincode buttons). We were setting the background of buttons without using the compat library tag and then the crash on old devices. We were setting the background by using I didn't notice the crash yesterday because I tested changes in Please, check both wp-android and Sample app. I tested the library on both apps, on a 4.4 device and on a 7.0 device, without having errors. |
PassGoogle Pixel on Android 7.1 with PasscodeLock Sample 1.0
|
Fix #43 by switching to
PreferenceChangeListeneron the PasscodeLock toggle.By setting up a listener on the
onChangesevent, the listener is called even when the user taps on the toggle UI item (most right of the screen). Instead by hooking uponClickthe listener is only called when the user taps on the text/row, but not the actual toggle.cc @theck13
Please test this intensively ;) Don't want to break PasscodeLock on newest devices :)