Offline Support : Pages - PageListEventListener uploadStatus not cleared on error

[jd-alexander]

Expected behavior

When an update is being made on a post and an error occurs the ProgressState should be updated to reflect this.

Actual behavior

This should be invoked whether an error has took place or not since it will update the status.

WordPress-Android/WordPress/src/main/java/org/wordpress/android/viewmodel/pages/PageListEventListener.kt

Line 102 in 1adbfd7

invalidateUploadStatus.invoke(

At the moment, the invocation only occurs if the event doesn't have an error.

Similar behavior in PostListEventListener

WordPress-Android/WordPress/src/main/java/org/wordpress/android/ui/posts/PostListEventListener.kt

Line 125 in be1eff3

invalidateUploadStatus.invoke(

Steps to reproduce the behavior

1. Update/Upload a post.
2. Create some form of error by manipulating the environment eg. disabling the internet during an upload.

Tested on Google Pixel 3a, Android 10, WPAndroid #11191

[malinajirka]

Does it have any impact on the UX? Eg. is the progress bar still shown when an error occurs?