Skip to content

[Editor] Make sure editor session starts (with content_type=new) matches post_created event #10097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniloercoli merged 2 commits into from
Jun 25, 2019
Merged

[Editor] Make sure editor session starts (with content_type=new) matches post_created event #10097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29b6fe9
Make sure editor session starts (with `content_type=new`) event match…
daniloercoli Jun 24, 2019
c92bfad
Fix lint
daniloercoli Jun 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,11 +394,12 @@ private void newPostSetup() {
mShortcutUtils.reportShortcutUsed(Shortcut.CREATE_NEW_POST);
}

private void createPostEditorAnalyticsSessionTracker(boolean showGutenbergEditor, PostModel post, SiteModel site) {
private void createPostEditorAnalyticsSessionTracker(boolean showGutenbergEditor, PostModel post, SiteModel site,
boolean isNewPost) {
if (mPostEditorAnalyticsSession == null) {
mPostEditorAnalyticsSession = new PostEditorAnalyticsSession(
showGutenbergEditor ? Editor.GUTENBERG : Editor.CLASSIC,
post, site);
post, site, isNewPost);
}
}

Expand Down Expand Up @@ -531,7 +532,7 @@ protected void onCreate(Bundle savedInstanceState) {
}

// ok now we are sure to have both a valid Post and showGutenberg flag, let's start the editing session tracker
createPostEditorAnalyticsSessionTracker(mShowGutenbergEditor, mPost, mSite);
createPostEditorAnalyticsSessionTracker(mShowGutenbergEditor, mPost, mSite, mIsNewPost);

// Bump post created analytics only once, first time the editor is opened
if (mIsNewPost && savedInstanceState == null) {
Expand Down
6 changes: 2 additions & 4 deletions WordPress/src/main/java/org/wordpress/android/ui/posts/PostEditorAnalyticsSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package org.wordpress.android.ui.posts;

import android.text.TextUtils;

import org.wordpress.android.analytics.AnalyticsTracker;
import org.wordpress.android.analytics.AnalyticsTracker.Stat;
import org.wordpress.android.fluxc.model.PostModel;
Expand Down Expand Up @@ -47,7 +45,7 @@ enum Outcome {
PUBLISH
}

PostEditorAnalyticsSession(Editor editor, PostModel post, SiteModel site) {
PostEditorAnalyticsSession(Editor editor, PostModel post, SiteModel site, boolean isNewPost) {
// fill in which the current Editor is
mCurrentEditor = editor;

Expand All @@ -69,7 +67,7 @@ enum Outcome {

// fill in mContentType
String postContent = post.getContent();
if (TextUtils.isEmpty(post.getContent())) {
if (isNewPost) {
mContentType = "new";
} else if (PostUtils.contentContainsGutenbergBlocks(postContent)) {
mContentType = "gutenberg";
Expand Down