Issue/update pages item ui - #11257
Merged
jd-alexander merged 4 commits intoFeb 12, 2020
Merged
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
added
[Status] Needs Design Review
Contributor
|
I reviewed this and it works as expected! I’m going to review again today. The design review has to be completed before this is merged right ? |
Contributor
Author
I think that'd be ideal since I didn't confirm this change with a designer. It just felt weird the two list were looking differently + I needed more space for the labels. |
3 tasks
Contributor
Author
|
@jd-alexander I've talked to Shakti and I'd suggest merging this PR since other PRs are based on this branch. We are merging it into a working branch so it won't get released to our users before the design review is done. Thanks! |
jd-alexander
changed the base branch from
issue/page_progress_bar
to
feature/master-pages-offline-support
February 12, 2020 20:07
|
The rows match post lists - lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #11133
Merge instructions:
master_page_offline_supportUpdates the layout of the PageList list items to match the layout of PostList items. I've copy pasted the post list compact item layout so there shouldn't be any issues.
To test:
We'll continue working on the PageList. So I don't think we need to do detailed tests.
PR submission checklist:
RELEASE-NOTES.txtif necessary.cc @mbshakti Could you please just quickly check the design. I think it should exactly match the design on PostList, but just to be sure I didn't overlook something (one difference is, that the "Local changes" label isn't yellow - we plan to add this in a different PR). Thanks!