Issue/11128 page label colors - #11280
Merged
jd-alexander merged 9 commits intoFeb 12, 2020
Merged
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
3 tasks
…age-label-colors # Conflicts: # WordPress/src/main/java/org/wordpress/android/viewmodel/pages/CreatePageListItemLabelsUseCase.kt
jd-alexander
approved these changes
Feb 12, 2020
jd-alexander
left a comment
jd-alexander
left a comment
Contributor
There was a problem hiding this comment.
Looks good Jirka! LGTM once the other PR is merged!
jd-alexander
changed the base branch from
issue/11133-update-page-item-labels
to
feature/master-pages-offline-support
February 12, 2020 23:03
…page-label-colors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11128
Review instructions:
Adds colors to page list items. The business logic was copy-pasted from PostListItemUiStateHelper.
I decided not to add any unit tests at the moment. The main reason is that I'm still considering rewriting this logic in both post-page list from scratch since it feels a bit weird that we evaluate the state of the PostModel twice -> labels + label colors.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.