Skip to content

Fix upload status cache issue - #11315

Merged
jd-alexander merged 2 commits into
feature/master-pages-offline-supportfrom
fix-upload-status-cache-issue
Feb 15, 2020
Merged

Fix upload status cache issue#11315
jd-alexander merged 2 commits into
feature/master-pages-offline-supportfrom
fix-upload-status-cache-issue

Conversation

@malinajirka

@malinajirka malinajirka commented Feb 14, 2020

Copy link
Copy Markdown
Contributor

Fixes #11303

A single instance of PostModelUploadStatusTracker is injected into PagesViewModel and reused in all the child view models. This fixes the issue as all the vms are working with the same instance and the cache is always up to date.

To test:

  1. Smoke Test: Try to publish a post and make sure the progress bar indicator is shown

I tested it by merging this branch into #11266 and:

  1. Open Page list
  2. Turn on airplane mode
  3. Open a page and make changes
  4. Click on Update/Publish
  5. Find the page in the page list
  6. Click on the "Cancel" action
  7. Make sure the Cancel action disappears

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added this to the 14.3 milestone Feb 14, 2020
@malinajirka
malinajirka changed the base branch from develop to feature/master-pages-offline-support February 14, 2020 16:01
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Feb 14, 2020

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

@jd-alexander jd-alexander left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes Jirka! Tested and it works as expected! LGTM 🚢

@jd-alexander
jd-alexander merged commit 62c6f3b into feature/master-pages-offline-support Feb 15, 2020
@jd-alexander
jd-alexander deleted the fix-upload-status-cache-issue branch February 15, 2020 01:09
@malinajirka malinajirka modified the milestones: 14.3, 14.6 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Offline Support : Pages - PostModelUploadStatusTracker scoping issue

2 participants